https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 --- Comment #1 from Florian <florian.bontemps@biblibre.com> --- Created attachment 136742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136742&action=edit Bug 31067: Fixing missing permission check This patch just fixes a missing permission on the intranet main page. Currently, the Additional Content modules allows people to edit, modify or create new additional content just by checking if they have any tool permission at all, and not the right one. To test: 1 - From the staff client, create a news article for the intranet. 2 - Create (or use) an additional staff patron, giving them the necessary permissions to access the intranet, but no tool permission. 3 - Using another browser (or incognito mode), log on the intranet page with your new staff account, you should be able to see the news content, but not edit or delete it. That's the expected behavior. 4 - From your main admin account, give your test account the edit_additional_contents permission. 5 - Your test account should now be able to edit/delete the news content. This is also expected behavior. 6 - Using the main account again, remove this time the edit_additional_contents but add any other subtool permission (edit_calendar is a good one for instance) 7 - Repeat step 5 and confirm that your test account can still edit or delete the news content. This shouldn't happen. 8 - Apply patch 9 - Repeat steps 4-6, and confirm that your test account can now only edit or delete news content if they have the edit_additional_contents permission enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |florian.bontemps@biblibre.c |ity.org |om CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136745|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137200&action=edit Bug 31067: Fixing missing permission check This patch just fixes a missing permission on the intranet main page. Currently, the Additional Content modules allows people to edit, modify or create new additional content just by checking if they have any tool permission at all, and not the right one. To test: 1 - From the staff client, create a news article for the intranet. 2 - Create (or use) an additional staff patron, giving them the necessary permissions to access the intranet, but no tool permission. 3 - Using another browser (or incognito mode), log on the intranet page with your new staff account, you should be able to see the news content, but not edit or delete it. That's the expected behavior. 4 - From your main admin account, give your test account the edit_additional_contents permission. 5 - Your test account should now be able to edit/delete the news content. This is also expected behavior. 6 - Using the main account again, remove this time the edit_additional_contents but add any other subtool permission (edit_calendar is a good one for instance) 7 - Repeat step 5 and confirm that your test account can still edit or delete the news content. This shouldn't happen. 8 - Apply patch 9 - Repeat steps 4-6, and confirm that your test account can now only edit or delete news content if they have the edit_additional_contents permission enabled. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31067 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00, 22.05.04 |22.11.00, 22.05.04, released in| |21.11.11 Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com --- Comment #6 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.11. Good Game Florian and thank you everyone! -- You are receiving this mail because: You are watching all bug changes.