[Bug 42185] New: Too many dbh subroutines in C4::Context
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Bug ID: 42185 Summary: Too many dbh subroutines in C4::Context Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org We have _new_dbh dbh new_dbh ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |domm@plix.at -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196199&action=edit Bug 42185: Remove C4::Context::_new_dbh This looks trivial at first, but it's not, because of forking and the comment in C4::Context I don't think the comment makes sense, we need to retrieve a new dbh, and so passing the 'new' parameters to C4::Context->dbh should do the same. Test plan: Try rebuild_zebra.pl and confirm there is no error % perl misc/migration_tools/rebuild_zebra.pl --processes 2 -b -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196200&action=edit Bug 42185: Remove C4::Context->new_dbh This is not used! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 197249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197249&action=edit Bug 42185: Remove C4::Context::_new_dbh This looks trivial at first, but it's not, because of forking and the comment in C4::Context I don't think the comment makes sense, we need to retrieve a new dbh, and so passing the 'new' parameters to C4::Context->dbh should do the same. Test plan: Try rebuild_zebra.pl and confirm there is no error % perl misc/migration_tools/rebuild_zebra.pl --processes 2 -b Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 197250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197250&action=edit Bug 42185: Remove C4::Context->new_dbh This is not used! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |domm@plix.at |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Thomas Klausner <domm@plix.at> --- Test plan works, code change looks sane, go for it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Thomas Klausner <domm@plix.at> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197250|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #7 from Thomas Klausner <domm@plix.at> --- Created attachment 197330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197330&action=edit Bug 42185: Remove C4::Context::_new_dbh This looks trivial at first, but it's not, because of forking and the comment in C4::Context I don't think the comment makes sense, we need to retrieve a new dbh, and so passing the 'new' parameters to C4::Context->dbh should do the same. Test plan: Try rebuild_zebra.pl and confirm there is no error % perl misc/migration_tools/rebuild_zebra.pl --processes 2 -b Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #8 from Thomas Klausner <domm@plix.at> --- Created attachment 197331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197331&action=edit Bug 42185: Remove C4::Context->new_dbh This is not used! Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Thomas Klausner <domm@plix.at> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42185 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #10 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org