[Bug 8550] New: Z39.50 searches for ISBN/ISSN problematic
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Priority: P5 - low Change sponsored?: --- Bug ID: 8550 CC: m.de.rooy@rijksmuseum.nl Assignee: jcamins@cpbibliography.com Summary: Z39.50 searches for ISBN/ISSN problematic Severity: normal Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Copy cataloging via Z39.50 is often done by searching on ISBN or ISSN. Unfortunately, the code for doing this is... problematic, and may cause problems with some Z39.50 servers. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11273&action=edit Bug 8550: Z39.50 searches for ISBN/ISSN problematic Rather than treating ISBN and ISSN as the same, this patch breaks them out into separate parts of the query, as well as changing the truncation attribute to enable right truncation (the correct behavior for the ISBN field in MARC21, and valid behavior in UNIMARC). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway@gmail.com --- Comment #2 from Joseph Alway <jbalway@gmail.com> --- (In reply to comment #1)
Created attachment 11273 [details] Bug 8550: Z39.50 searches for ISBN/ISSN problematic
I finally got koha running off my git install and applied the patch. It works! :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11273|0 |1 is obsolete| | --- Comment #3 from Joseph Alway <jbalway@gmail.com> --- Created attachment 11304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11304&action=edit Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 11304 [details] Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off Signed-off-by: Joseph Alway <jbalway@gmail.com>
patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * bc4a87d Bug 8550: Z39.50 searches for ISBN/ISSN problematic cataloguing/z3950_search.pl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 Thank you very much for your sign off Joseph -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed (Joseph Alway, if I'm not mistaking, it's your 1st signoff = congratulations & welcomed !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... maybe i've be a little to fast in pushing this patch: Jared, in z3950_search.pl, I see: <li><label for="isbn">ISBN/ISSN: </label> <input type="text" id="isbn" name="isbn" value="[% isbn %]" /></li> There is no field called issn, so $query->param('issn') is always empty and that's some dead code (which was partially already here before, I agree) Am I right or do I have missed something ? (however, patch already pushed, but please answer -and provide a fix if needed !-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11304|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 11936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11936&action=edit Bug 8550: restore ISSN field to Z39.50 search Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13. To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Paul, What you were missing was the second patch for this bug, which I failed to attach. I have now done so. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Simple patch, provides the last of the clean up needed to undo a regression. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11936|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11940&action=edit Bug 8550: restore ISSN field to Z39.50 search Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13. To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #11)
Created attachment 11940 [details] Bug 8550: restore ISSN field to Z39.50 search
Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature.
A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13.
To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit ec365ff) * 301dd72 Bug 8550: restore ISSN field to Z39.50 search koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway <jbalway@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master --- Comment #13 from Joseph Alway <jbalway@gmail.com> --- All of the same problems exist in the file /usr/share/koha/intranet/cgi-bin/acqui/z3950_search.pl as noted in bug 8680. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Follow-up pushed to master (thx jared) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #16 from Nicole C. Engard <nengard@gmail.com> --- *** Bug 8254 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This is working in Master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11304|1 |0 is obsolete| | CC| |dcook@prosentient.com.au --- Comment #18 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 11304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11304 Bug 8550: Z39.50 searches for ISBN/ISSN problematic - Signed Off The first patch was obsoleted, but is needed for folks doing a git bz apply for versions older than 3.8.4 (which hopefully they shouldn't need to do, but still...) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org