[Bug 27865] New: Hold pickup location dropdown on patron pages should respect hold fulfillment policies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Bug ID: 27865 Summary: Hold pickup location dropdown on patron pages should respect hold fulfillment policies Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Same as bug 27864 but for patron account pages on staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2786 [Bug 2786] Allow waiting holds to be diverted to different branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Depends on|2786 |27863 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2786 [Bug 2786] Allow waiting holds to be diverted to different branch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 [Bug 27863] Holds API route for pickup_libraries should return all branches if 'AllowHoldPolicyOverride' is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Bug 27865 depends on bug 27863, which changed state. Bug 27863 Summary: Add a way to override constraints on pickup_libraries route if 'AllowHoldPolicyOverride' is enabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Bug 27865 depends on bug 27863, which changed state. Bug 27863 Summary: Cannot select different pickup locations even with AllowHoldsPolicyOverride on request.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27863 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27898 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27898 [Bug 27898] Make PUT /holds/:hold_id handle x-koha-override for pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |27205 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This was caused by bug 27205. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 [Bug 27205] Hold routes are not dealing with invalid pickup locations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 117941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117941&action=edit Bug 27865: Pass the x-koha-override header to PUT /holds/:hold_id from the patron's page This patch makes the AJAX call to update an existing hold, pass the 'x-koha-override' header with the value of 'any', so any pickup location policy override that is needed, is applied. As the override is taken into account only if AllowHoldPolicyOverride is enabled, this in fact restores the previous behavior. To test: 1. Have a patron with a hold 2. Have AllowHoldPolicyOverride set to 'yes' 3. Try changing the pickup location to an invalid one => FAIL: The options are the same as before 27205, yet the AJAX call fails because of invalid pickup location. 4. Apply this patch 5. Repeat 3 => SUCCESS: The API call succeeds, and the hold is updated (it is actually refetch, so just verify it has the value you selected 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117941|0 |1 is obsolete| | --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 118119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118119&action=edit Bug 27865: Pass the x-koha-override header to PUT /holds/:hold_id from the patron's page This patch makes the AJAX call to update an existing hold, pass the 'x-koha-override' header with the value of 'any', so any pickup location policy override that is needed, is applied. As the override is taken into account only if AllowHoldPolicyOverride is enabled, this in fact restores the previous behavior. To test: 1. Have a patron with a hold 2. Have AllowHoldPolicyOverride set to 'yes' 3. Try changing the pickup location to an invalid one => FAIL: The options are the same as before 27205, yet the AJAX call fails because of invalid pickup location. 4. Apply this patch 5. Repeat 3 => SUCCESS: The API call succeeds, and the hold is updated (it is actually refetch, so just verify it has the value you selected 6. Sign off :-D Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a lot of bugs depending on this I feel would be in better hands with other QA team members, but I wanted to test the end result a bit: I am not sure if this works correctly. I am testing this right after bug 27894 with the same holds. For my holds, I only allow the pick-up location = item's home library. Also Fairview is set to be no pickup location on library level. In the patron account, on details and checkouts tabs: - Fairview doesn't show up - OK - All other libraries show independent of the AllowHoldPolicyOverride setting - NOT OK. With Don't allow only the home library of the item should be available. - In comparison: for the same holds, the pull down on detail page > holds only shows the home library as expected with the stricter setting. Should we not also establish a visual warning here like 27894 does? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #4)
There is a lot of bugs depending on this I feel would be in better hands with other QA team members, but I wanted to test the end result a bit:
I am not sure if this works correctly. I am testing this right after bug 27894 with the same holds.
For my holds, I only allow the pick-up location = item's home library. Also Fairview is set to be no pickup location on library level.
In the patron account, on details and checkouts tabs: - Fairview doesn't show up - OK - All other libraries show independent of the AllowHoldPolicyOverride setting - NOT OK. With Don't allow only the home library of the item should be available. - In comparison: for the same holds, the pull down on detail page > holds only shows the home library as expected with the stricter setting.
Should we not also establish a visual warning here like 27894 does?
Yeah, adding the visual feedback here would be helpful. The idea here was to provide a backportable fix to a regression, though. Will fix it to make it show all pickup locations only if AllowHoldPolicyOverride is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I now recall it. This bug wasn't about fixing the dropdown, but fixing the PUT, which was failing even though the dropdown presents the libraries to override. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #6)
I now recall it. This bug wasn't about fixing the dropdown, but fixing the PUT, which was failing even though the dropdown presents the libraries to override.
So I should be able to change the pickup location to an invalid one or only when the override is possible? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #7)
(In reply to Tomás Cohen Arazi from comment #6)
I now recall it. This bug wasn't about fixing the dropdown, but fixing the PUT, which was failing even though the dropdown presents the libraries to override.
So I should be able to change the pickup location to an invalid one or only when the override is possible?
Only when the override is possible. The PUT route should reject the request. But that's not in the scope of this bug. That is taken care of on bug 27898, and it is correctly tested in my opinion. What you might be facing here, is wrong dropdown rendering. Which could be solved the way we did in bug 27894 and friends. As I said, the idea was to make it easy to backport this, and move the dropdown rendering into using Select2 + API + visual feedback on overrides, on a separate bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28254 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28254 [Bug 28254] Make it possible to override rules in PUT /holds/:hold_id/pickup_location -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118119|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120291&action=edit Bug 27865: Pass the x-koha-override header to PUT /holds/:hold_id from the patron's page This patch makes the AJAX call to update an existing hold, pass the 'x-koha-override' header with the value of 'any', so any pickup location policy override that is needed, is applied. As the override is taken into account only if AllowHoldPolicyOverride is enabled, this in fact restores the previous behavior. To test: 1. Have a patron with a hold 2. Have AllowHoldPolicyOverride set to 'yes' 3. Try changing the pickup location to an invalid one => FAIL: The options are the same as before 27205, yet the AJAX call fails because of invalid pickup location. 4. Apply this patch 5. Repeat 3 => SUCCESS: The API call succeeds, and the hold is updated (it is actually refetch, so just verify it has the value you selected 6. Sign off :-D Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120291|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120308&action=edit Bug 27865: Pass the x-koha-override header to PUT /holds/:hold_id from the patron's page This patch makes the AJAX call to update an existing hold, pass the 'x-koha-override' header with the value of 'any', so any pickup location policy override that is needed, is applied. As the override is taken into account only if AllowHoldPolicyOverride is enabled, this in fact restores the previous behavior. To test: 1. Have a patron with a hold 2. Have AllowHoldPolicyOverride set to 'yes' 3. Try changing the pickup location to an invalid one => FAIL: The options are the same as before 27205, yet the AJAX call fails because of invalid pickup location. 4. Apply this patch 5. Repeat 3 => SUCCESS: The API call succeeds, and the hold is updated (it is actually refetch, so just verify it has the value you selected 6. Sign off :-D Signed-off-by: Petro Vashchuk <stalkernoid@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28261 [Bug 28261] Add visual feedback on overridden pickup locations on patron's page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27865 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Dependencies not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org