[Bug 5399] New: remove useless eval 'use C4::Foo'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 Summary: remove useless eval 'use C4::Foo' Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: gmcharlt@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 A couple scripts use constructs like this: eval "use C4::Acquisition qw/GetBasket/;"; I can think of no good reason to do this for standard C4 modules, especially since the code never checked to see if the eval succeeded. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 --- Comment #1 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-12 19:16:15 UTC --- This bug is mentioned in: bug 5399: remove useless eval 'use C4::Foo' http://lists.koha-community.org/pipermail/koha-patches/2010-November/012966.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch Status|Needs Signoff |Signed Off --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-01-17 09:17:40 UTC --- Signed patch (updated for current master) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-17 10:01:51 UTC --- Patch, and follow up patch pushed Would still like to see a fix to the use $pdfformat bit -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 --- Comment #4 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-05 19:00:54 UTC --- This bug is mentioned in: Bug 5399: remove useless eval 'use C4::Foo' http://lists.koha-community.org/pipermail/koha-patches/2011-January/013608.h... Bug 5399: remove useless eval 'use C4::Foo' http://lists.koha-community.org/pipermail/koha-patches/2011-January/013609.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5399 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org