[Bug 31928] New: Add page-section to callnumber browser value builder (cat)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Bug ID: 31928 Summary: Add page-section to callnumber browser value builder (cat) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 30952 Blocks: 31757 The cn_browser.pl value builder uses a pop-up window with a big table inside. the page section would help here with it's white background color. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 143582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143582&action=edit Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143582|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 143594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143594&action=edit Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I noticed some "weird" behaviour with the results section: - The first time you search (for example, "a"), there is a darker green line under the column headers - If you then search for something else (for example, "s") the dark green line moves to the bottom - Repeat searching for different terms, and the green line swaps about - If there is more than one result (I added some call numebrs to items), it does the same I'm not familiar with searching using the value builder, so it may be a feature - particularly where all items have call numbers (as there are not many in the same data). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143594|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143606&action=edit Bug 31928: Add page-section to callnumber browser value builder (cat) This patch adds a page-section div around the search results shown by the call number browser plugin in Cataloging. The patch also restructures the search form so that the layout is correct. To test you must have an item subfield linked to the call number browser plugin: - Go to MARC frameworks -> Default MARC framework -> MARC structure. - Locate the 952 tag and click Actions -> Edit subfields. - Open the "o" tab and in the last section, "Other options," choose "cn_browser.pl" for the plugin field. Open an item record for editing: - Go to Cataloging and search for a bibliographic record. - Click Actions -> Add/Edit items for one of the results. - In the item edit form, the "o - Full call number" field should have a "..." link at the end. - Clicking it should trigger a popup window. - The search form at the top should be laid out correctly. - Perform a search which will return results. - The table of results should be contained within a white box. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31928 Bug 31928 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org