[Bug 10330] New: Rename system preference authoritysep to AuthoritySeperator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bug ID: 10330 Summary: Rename system preference authoritysep to AuthoritySeperator Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Blocks| |10327 Assignee|gmcharlt@gmail.com |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18379&action=edit Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Maybe there's something wrong with my files, but I think you need a rebase. Applying: Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 10330 - Rename system preference authoritysep to AuthoritySeperator -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18379|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26941&action=edit Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 26942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26942&action=edit Bug 10330 - Follow up - missed case of authoritysep $ git grep authoritysep This showed: 1) the updatedatabase.pl script, as expected, 2) lots of po files, 3) a test file that was missed. TEST PLAN --------- 1) prove -v t/db_dependent/Search.t 2) Run koha QA test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Summary|Rename system preference |Rename system preference |authoritysep to |authoritysep to |AuthoritySeperator |AuthoritySeparator -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. Tompsett from comment #3)
Created attachment 26941 [details] [review] Bug 10330 - Rename system preference authoritysep to AuthoritySeperator
Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use
Mark, this first one is signed? Or, Are you considering to sign it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- I signed off the first one. The second (Follow up...) I wrote. It is NOT signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Hmmm... on second thought, just consider nothing signed. I may have just rebased, since I don't have a 10330 branch in my unimarc vm. I have been trying to save things from the patch does not apply pile. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26941|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27903&action=edit [SIGNED-OFF] Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26942|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27904&action=edit [SIGNED-OFF] Bug 10330 - Follow up - missed case of authoritysep $ git grep authoritysep This showed: 1) the updatedatabase.pl script, as expected, 2) lots of po files, 3) a test file that was missed. TEST PLAN --------- 1) prove -v t/db_dependent/Search.t 2) Run koha QA test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work (both patches). Test pass. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27903|0 |1 is obsolete| | Attachment #27904|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28118&action=edit Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No koha-qa errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28119&action=edit Bug 10330 - Follow up - missed case of authoritysep $ git grep authoritysep This showed: 1) the updatedatabase.pl script, as expected, 2) lots of po files, 3) a test file that was missed. TEST PLAN --------- 1) prove -v t/db_dependent/Search.t 2) Run koha QA test tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work (both patches). Test pass. No koha-qa errors Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com Severity|trivial |enhancement --- Comment #12 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org