[Bug 32618] New: Add 'page-section' to various administration pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Bug ID: 32618 Summary: Add 'page-section' to various administration pages Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 Several administration templates need to have main content wrapped in a "page-section" container. - admin/aqcontract.tt - admin/aqplan.tt - admin/desks.tt - admin/oai_set_mappings.tt - admin/overdrive.tt - admin/sms_providers.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145242&action=edit Bug 32618: Add 'page-section' to various administration pages This patch adds a "page-section" container div around the main section of administration pages which lack it. The SMS providers page required a small change to the associated JavaScript in order to target the right container, so you may need to clear your browser cache to get the correct behavior. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Contracts - Administration -> Budgets -> Budget details -> Planning - Administration -> Circulation desks - Administration -> OAI sets configuration -> Define mappings - Administration -> System preferences -> Search for 'OverDriveAuthName' -> OverDrive library authnames table - Administration -> SMS cellular providers - Confirm that the "Edit" buttons work correctly to show and hide the right content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145242|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145245&action=edit Bug 32618: Add 'page-section' to various administration pages This patch adds a "page-section" container div around the main section of administration pages which lack it. The SMS providers page required a small change to the associated JavaScript in order to target the right container, so you may need to clear your browser cache to get the correct behavior. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Contracts - Administration -> Budgets -> Budget details -> Planning - Administration -> Circulation desks - Administration -> OAI sets configuration -> Define mappings - Administration -> System preferences -> Search for 'OverDriveAuthName' -> OverDrive library authnames table - Administration -> SMS cellular providers - Confirm that the "Edit" buttons work correctly to show and hide the right content. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For circulation desks, enable UseCirculationDesks. 2. For SMS cellular providers, enable SMSSendDriver (I used Email). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) The 'new contract' form has the save button inside the page-section. Should it not be outside? 2) aqplan.tt: Save button here is also inside the page-section. 3) oai_set_mapping.tt: Same as above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Have we established a style guideline for save buttons? I know we're inconsistent, but I don't know that we have set down a rule yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I have filed this bug to deal with save button consistency: Bug 32744: [OMNIBUS] Standardize structure around action fieldsets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #6)
I have filed this bug to deal with save button consistency:
Bug 32744: [OMNIBUS] Standardize structure around action fieldset
Agreed, let's get this in and then work on making things (even more) consistent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145245|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 145829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145829&action=edit Bug 32618: Add 'page-section' to various administration pages This patch adds a "page-section" container div around the main section of administration pages which lack it. The SMS providers page required a small change to the associated JavaScript in order to target the right container, so you may need to clear your browser cache to get the correct behavior. This patch contains indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the main content is contained in a white box: - Acquisitions -> Vendor -> Contracts - Administration -> Budgets -> Budget details -> Planning - Administration -> Circulation desks - Administration -> OAI sets configuration -> Define mappings - Administration -> System preferences -> Search for 'OverDriveAuthName' -> OverDrive library authnames table - Administration -> SMS cellular providers - Confirm that the "Edit" buttons work correctly to show and hide the right content. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 --- Comment #10 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32618 Bug 32618 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org