[Bug 40017] New: Z39.50 search: Allow leader and specific control field positions in Additional fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Bug ID: 40017 Summary: Z39.50 search: Allow leader and specific control field positions in Additional fields Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Would be nice to include things like 000p6-7 for position 6 and 7 of leader (field '000') 008p35-37 (pos 35-57, language) of 008 in the prefs for additional fields in Z39.50 search. AdditionalFieldsInZ3950ResultSearch AdditionalFieldsInZ3950ResultAuthSearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182821&action=edit Bug 40017: Add leader and control field positions to Z3950 search results Test plan: Run t/Breeding.t Set AdditionalFieldsInZ3950ResultSearch to 000p6, 008, 040$b Do some searches and check the Additional fields column of results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23017 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31726 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29885 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This allows you to extend release notes| |the related prefs | |AdditionalFieldsInZ3950Resu | |ltSearch and | |AdditionalFieldsInZ3950Resu | |ltAuthSearch with: | | | |[1] | |complete leader with 000 | |[2] complete control field | |with e.g. 008 | |[3] specific | |position in leader or | |controlfield 000p1, 008p2, | |etc. | |[4] range in | |leader/controlfield | |000p6-7, 008p35-37, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #2 from David Nind <david@davidnind.com> --- After applying the patch, Z39.50/SRU searches return results only for the LIBRARY OF CONGRESS SRU search target. Any other search target returns a 500 error. Testing notes (using KTD, MARC21): 1. Before applying the patch: - Set AdditionalFieldsInZ3950ResultSearch = 000p6, 008p35-37, 040$b - Go to Cataloguing > New from Z39.50/SRU > Books, Booklets, Workbooks - In the title enter: dita - Note that in the additional fields column, some of the returned records have additional information - such as the full 008 or the value of 040$b (none of the search results had any 001 values) 2. After applying the patch, restart everything (restart_all) and clear your browser cache. 3. If you repeat step 1, I sometimes got results. But most often I got an Error 500 page. (Before the patch, I didn't get any). With the sample targets in KTD: - I was only ever able to get results when using LIBRARY OF CONGRESS SRU - If LIBRARY OF CONGRESS or NATIONAL LIBRARY OF FRANCE were selected, I always got a 500 error - Before the patch: any combination of search targets returned results 4. The /var/log/koha/kohadev/plack-intranet-error.log only contains warnings: lots of [WARN] Use of uninitialized value ... 5. The tests pass: prove t/Breeding.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #2)
After applying the patch, Z39.50/SRU searches return results only for the LIBRARY OF CONGRESS SRU search target. Any other search target returns a 500 error.
Thats weird. I cant reproduce with the LOC server. The National Library of France times out with me. (What were your search fields and used terms.) For 500 errors, please check plack-error.log and extract the error description and the offending line from C4/Breeding from the trace.
4. The /var/log/koha/kohadev/plack-intranet-error.log only contains warnings: lots of [WARN] Use of uninitialized value ...
Please copy distinct warnings when these refer to the Breeding module. Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #3)
Thats weird. I cant reproduce with the LOC server. The National Library of France times out with me. (What were your search fields and used terms.)
Wait. I can reproduce now while looking more closely to your test plan. An seemingly important difference is starting from Books, Booklets, .. Looking further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 182902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182902&action=edit Bug 40017: (follow-up) More rigorous checking Adding a few checks to resolve the errors David found while testing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- David, the follow-up should take care of the errors you catched. Thanks. I got now results with the same pref value, for title=dita and targets LOC and France library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Mirjam Vantieghem <mirjam.vantieghem@etf.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182821|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 182939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182939&action=edit Bug 40017: Add leader and control field positions to Z3950 search results Test plan: Run t/Breeding.t Set AdditionalFieldsInZ3950ResultSearch to 000p6, 008, 040$b Do some searches and check the Additional fields column of results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182902|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 182940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182940&action=edit Bug 40017: (follow-up) More rigorous checking Adding a few checks to resolve the errors David found while testing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This allows you to extend |This enhancement to the release notes|the related prefs |AdditionalFieldsInZ3950Resu |AdditionalFieldsInZ3950Resu |ltSearch and |ltSearch and |AdditionalFieldsInZ3950Resu |AdditionalFieldsInZ3950Resu |ltAuthSearch system |ltAuthSearch with: |preferences improves what | |you can show for the |[1] |additional fields in the |complete leader with 000 |Z39.50 search results: |[2] complete control field | |with e.g. 008 |[1] |[3] specific |the complete leader with |position in leader or |000 |controlfield 000p1, 008p2, |[2] the complete |etc. |control field, for example |[4] range in |008 |leader/controlfield |[3] specific positions |000p6-7, 008p35-37, etc. |in the leader or control | |fields, for example 000p1, | |008p2, etc. | |[4] a range | |from the leader or control | |field, for example 000p6-7, | |008p35-37, etc. --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Marcel de Rooy from comment #6)
David, the follow-up should take care of the errors you catched. Thanks. I got now results with the same pref value, for title=dita and targets LOC and France library.
Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #9)
(In reply to Marcel de Rooy from comment #6)
David, the follow-up should take care of the errors you catched. Thanks. I got now results with the same pref value, for title=dita and targets LOC and France library.
Thanks Marcel!
U+1F44D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182939|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187655&action=edit Bug 40017: Add leader and control field positions to Z3950 search results Test plan: Run t/Breeding.t Set AdditionalFieldsInZ3950ResultSearch to 000p6, 008, 040$b Do some searches and check the Additional fields column of results. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182940|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187656&action=edit Bug 40017: (follow-up) More rigorous checking Adding a few checks to resolve the errors David found while testing. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188295&action=edit Bug 40017: (follow-up) Update GNU license link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- t/db_dependent/Breeding.t is now failing. git bisects blames this bug. Marcel, can you check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass (lukeg) from comment #15)
t/db_dependent/Breeding.t is now failing. git bisects blames this bug. Marcel, can you check?
Will check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 188398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188398&action=edit Bug 40017: (QA follow-up) Fix t/db/Breeding.t Although t/Breeding.t was adjusted, the t/db counterpart should have been adjusted too. The sort order was added, the subfield tag was moved. Test plan: Run test again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks Marcel, follow-up pushed to main! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is quite cool, but it would be nice if we had some examples in the system preference description. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41424 [Bug 41424] Add examples to the AdditionalFieldsInZ3950ResultSearch and AdditionalFieldsInZ3950ResultAuthSearch system preference descriptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 --- Comment #20 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #19)
This is quite cool, but it would be nice if we had some examples in the system preference description.
Have created bug 41424. I've added some examples, if I can get some comments on these I'll create a patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40017 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #21 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is a great new feature / enhancement but it will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org