[Bug 27352] New: Add GET /biblios/:biblio_id/items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Bug ID: 27352 Summary: Add GET /biblios/:biblio_id/items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com It would be helpful to have that route. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |lucas@bywatersolutions.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114892&action=edit Bug 27352: Add GET /biblios/:biblio_id/items This patch adds a route to fetch the items for a biblio. It relies entirely on already existing methods. To test: 1. Use your favourite REST tool 2. Play with the new route. => SUCCESS: It works as expected! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27034 [Bug 27034] $c->objects->search shouldn't use path parameters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114894&action=edit Bug 27352: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114895&action=edit Bug 27352: Missed case in bug 25032 Probably because of the order things got pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 [Bug 27358] Add GET /public/biblios/:biblio_id/items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114892|0 |1 is obsolete| | Attachment #114894|0 |1 is obsolete| | Attachment #114895|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114983&action=edit Bug 27352: Add GET /biblios/:biblio_id/items This patch adds a route to fetch the items for a biblio. It relies entirely on already existing methods. To test: 1. Use your favourite REST tool 2. Play with the new route. => SUCCESS: It works as expected! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114984&action=edit Bug 27352: Unit tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114985&action=edit Bug 27352: Missed case in bug 25032 Probably because of the order things got pushed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Works good with PostMan. I also play around with stuff like: let url = '/api/v1/biblios/144/items'; $.getJSON(url, function(data) { data.forEach(element => console.log(element.collection_code)); }); Just to see how it works. I really like this route. Also tests pass for me: prove -v t/db_dependent/api/v1/biblios.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114983|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115810&action=edit Bug 27352: Add GET /biblios/:biblio_id/items This patch adds a route to fetch the items for a biblio. It relies entirely on already existing methods. To test: 1. Use your favourite REST tool 2. Play with the new route. => SUCCESS: It works as expected! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114984|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115811&action=edit Bug 27352: Unit tests Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114985|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115812&action=edit Bug 27352: Missed case in bug 25032 Probably because of the order things got pushed. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's great to see these routes getting added.. Thanks for all your diligent work Tomas! Works great, all makes sense and passes QA scripts and Unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27034 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27352 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org