[Bug 27487] New: Rename system preference reviewson to OPACComments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Bug ID: 27487 Summary: Rename system preference reviewson to OPACComments Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org find all of the places in the code that refer to the 'reviewson' system preference and rename them to 'OPACComments' write an atomic update to rename the reviewson system preference to OPACComments in the preferences table in the database rename the reviewson syspref in sysprefs.sql refer to bug 10328 for an example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10327 Keywords| |Academy Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 [Bug 10327] Rename poorly named system preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mazen.i.khallaf@gmail.com Assignee|koha-bugs@lists.koha-commun |mazen.i.khallaf@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mazen.i.khallaf@gmail.com |jamespfk@gmail.com CC| |jamespfk@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 --- Comment #1 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115623&action=edit Bug 27487: Rename system preference reviewson to OPACComments This patch renames the reviewson system pref to OPACComments Test Plan: 1. In Koha Administration, search for the reviewson system preferance 2. Note the presence of the reviewson system preferance 3. Apply the patch and run updatedatabase.pl 4. Repeat steps 1 and 2. The reviewson preferenace should be gone 5. Seach for and note the OPACComments system preferance 6. Ensure that the OPACComments system preferance operates correctly, as if it were reviewson -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115623|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115713&action=edit Bug 27487: Rename system preference reviewson to OPACComments This patch renames the reviewson system pref to OPACComments Test Plan: 1. In Koha Administration, search for the reviewson system preferance 2. Note the presence of the reviewson system preferance 3. Apply the patch and run updatedatabase.pl 4. Repeat steps 1 and 2. The reviewson preferenace should be gone 5. Seach for and note the OPACComments system preferance 6. Ensure that the OPACComments system preferance operates correctly, as if it were reviewson Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mazen.i.khallaf@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115713|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115995&action=edit Bug 27487: Rename system preference reviewson to OPACComments This patch renames the reviewson system pref to OPACComments Test Plan: 1. In Koha Administration, search for the reviewson system preferance 2. Note the presence of the reviewson system preferance 3. Apply the patch and run updatedatabase.pl 4. Repeat steps 1 and 2. The reviewson preferenace should be gone 5. Seach for and note the OPACComments system preferance 6. Ensure that the OPACComments system preferance operates correctly, as if it were reviewson Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=27484 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This renames the existing release notes| |system preference | |'reviewson' to | |'OPACComments' which better | |reflects its use. Keywords|Academy |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27487 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Manual | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org