[Bug 37231] New: (Bug 34940 follow-up) Highlight logged-in library in facets does not work with ES
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Bug ID: 37231 Summary: (Bug 34940 follow-up) Highlight logged-in library in facets does not work with ES Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org The highlight logged-in library in facets feature does not work with Elasticsearch. This is because facet_title_value contains an additional " (count)" information and so gives negative results in comparisons made in facets.inc (line 107). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 168361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168361&action=edit Bug 37231: (Bug 34940 follow-up) Highlight logged-in library in facets does not work with ES The highlight logged-in library in facets feature does not work with Elasticsearch. This is because facet_title_value contains an additional " (count)" information and so gives negative results in comparisons made in facets.inc (line 107). Test plan: ========== 1. Have a test installation with Elastiscsearch. 2. Set system preference 'DisplayLibraryFacets' to 'both home and holding libraries' 3. Perform a seach that will find items of your logged-in library. In KTD, search for 'branch:CPL' 4. Check the facet (home and holding libraries) of your logged-in library is not highlighted 5. Apply the patch ; restart_all. 6. Repeat p. 3. Check the facet (home and holding libraries)--you should see your logged-in branch highlighted now. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |34940 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34940 [Bug 34940] Highlight logged-in library in facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168361|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 168407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168407&action=edit Bug 37231: (Bug 34940 follow-up) Highlight logged-in library in facets does not work with ES The highlight logged-in library in facets feature does not work with Elasticsearch. This is because facet_title_value contains an additional " (count)" information and so gives negative results in comparisons made in facets.inc (line 107). Test plan: ========== 1. Have a test installation with Elastiscsearch. 2. Set system preference 'DisplayLibraryFacets' to 'both home and holding libraries' 3. Perform a seach that will find items of your logged-in library. In KTD, search for 'branch:CPL' 4. Check the facet (home and holding libraries) of your logged-in library is not highlighted 5. Apply the patch ; restart_all. 6. Repeat p. 3. Check the facet (home and holding libraries)--you should see your logged-in branch highlighted now. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Got a bit confused here, but it looks like it only works in the staff interface! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Katrin Fischer from comment #3)
Got a bit confused here, but it looks like it only works in the staff interface!
This is right. The Fridolin's intention in Bug 34940 was to correct intranet-tmpl/prog/en/includes/facets.inc only. Here I just fixed what was not working for ES. If somebody wanted to extend Bug 34940 to OPAC, the current fix for ES should work as well without additional changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37231 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org