[Bug 27539] New: Console warnings "Use of uninitialized value in split" on "Holds to pull" page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Bug ID: 27539 Summary: Console warnings "Use of uninitialized value in split" on "Holds to pull" page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: stalkernoid@gmail.com Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com, nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 115731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115731&action=edit Bug 27539: fix console warnings "Use of uninitialized value in split" When items in the database have NULLs for some fields, those are SELECTed as undefs and those values arrive as strings to be splitted by "split" command, and that produces undef warnings. That is expected behaviour to not have data for those fields sometimes, so we just need to add perl's "defaulting" to empty strings for split. To reproduce: 1) Place a hold on an item that has an available call number, copy numbers or enumeration empty. 2) Head to the Holds to Pull page and check the console to see "Use of uninitialized value in split" errors. 3) Apply the patch. 4) Refresh the Holds to Pull page and check the console again to ensure that new errors about "Use of uninitialized value in split" weren't added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Console warnings "Use of |Warnings "Use of |uninitialized value in |uninitialized value in |split" on "Holds to pull" |split" on "Holds to pull" |page |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Peter. I can't seem to replicate the warning message appearing in any of the log files or the browser console. I have checked the database for the items I have placed holds on and they have NULL as the value for call number, copy number and enumeration. Have tried both a record level and an item level hold. I'm testing using koha-testing-docker and on master. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 --- Comment #3 from Peter Vashchuk <stalkernoid@gmail.com> --- (In reply to David Nind from comment #2) Hey David. Looks like since commit 2285c2d6 the file structure in the master changed pretty drastically, it moved away from raw SQL SELECT to DBIx::Class, which means no more "splits" that produce this exact warning. Basically what you're saying is correct, ticket and patch are obsolete now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Peter for having a look. It's good that it is fixed! I have changed the status for this bug to resolved. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org