https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54784&action=edit Bug 17152: Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54784|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 54996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54996&action=edit [SIGNED-OFF]Bug 17152: Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- The value is no longer copied, but neither is the subfield code Example: I copy 260$b I get a new blank 260$_ (though the field description states "Name of publisher, distributor, etc" We should copy the subfield code but not the contents -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54996|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 55078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55078&action=edit Bug 17152: (counter-patch)Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |hector.hecaxmmx@gmail.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55079|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55234&action=edit Bug 17152: (counter-patch)Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55234|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55276&action=edit Bug 17152: Do not copy value when duplicating a subfield When cataloguing, if you want to duplicate a subfield that is not empty, the new subfield is created with a copy of data in it. This is not the case when you duplicate an whole field. The new one is created with subfields but without data in it. Test plan: Add or edit a bibliographic record Fill a subfield Duplicate the subfield => Without this patch the value of the input will be copied => With this patch the new input will be emptied Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.04. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17152 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17477 [Bug 17477] Duplicating a subfield yields an empty subfield tag -- You are receiving this mail because: You are watching all bug changes.