[Bug 12146] Add new ISO code column to currency sample files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12146 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 206839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206839&action=edit Bug 12146: Add full ISO 4217 currency list to sample currency data The "Some basic currencies" optional sample dataset (installer/data/mysql/en/optional/parameters.yml) only offered four currencies (USD, GBP, CAD, EUR) and never populated currency.isocode, so every sample currency's ISO code was blank after install. Keep the existing curated set as-is (USD active by default, GBP/CAD/ EUR with their existing rates and symbols) and add the remaining active ISO 4217 currency codes as inactive options, each with isocode set to its own code and its common currency symbol/abbreviation (sourced from Wikipedia's "List of circulating currencies", with a handful of targeted lookups for entries missing there). A number of currencies legitimately share the same symbol (e.g. "$" is used by over twenty of them) - that's harmless here since only the single active currency's symbol is ever used for price formatting; the rest are purely informational in the admin currency list. Precious-metal and special codes (XAU, XAG, XPD, XPT, XTS, XXX, XDR, XBA-XBD, XSU, XUA) are excluded as they don't represent real acquisitions currencies. rate is set to a neutral 1.0 placeholder for the generated entries, since a static sample file can't hold meaningful live exchange rates for 150+ currencies. Relies on the earlier commit in this series resizing currency.isocode to CHAR(3), so every isocode value here is guaranteed to fit. Test plan: 1) Run a fresh web installer, select "Some basic currencies..." under Optional data at the Default Settings step 2) Go to Administration > Currencies & Exchange rates 3) Confirm ~154 currencies are listed, each with a 3-letter ISO code and a currency symbol, and only USD is active -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org