[Bug 13986] New: Printing a list only prints the results of the page you are viewing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Bug ID: 13986 Summary: Printing a list only prints the results of the page you are viewing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The print list button only prints the page you are viewing, and not the entire list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37761&action=edit Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 37773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37773&action=edit [Signed-off] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #37761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38192&action=edit Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Attachment #38192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38291&action=edit Bug 13986 - Implement fix for OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 38305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38305&action=edit [Signde-off] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38291|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, patch does not apply and I am not sure how to fix the conflict - better leaving it to you. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37773|0 |1 is obsolete| | Attachment #38305|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38496&action=edit Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38497&action=edit Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have started testing this - is there a way we could have the 'print preview' match what is actually going to be printed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #10 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #9)
I have started testing this - is there a way we could have the 'print preview' match what is actually going to be printed?
I think there is now way to trigger the print preview from JavaScript, because the print preview is part of the browser. One workaround could be to create a separate page for printing, but that would be a different approach (and not a real print preview). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Please provide tests for the changes in C4::VirtualShelves. I don't know if you feel comfortable with this code, but personally I am not at all. So maybe the better is to start and move the code into Koha::VirtualShelves. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #11)
So maybe the better is to start and move the code into Koha::VirtualShelves.
Since your changes consist in adding a check, it's certainly a bit hard to start here... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- C4::VirtualShelves has no unit tests. Further complicating the issue is that the code relies on CGI objects. I think the two small changes I made to C4::VirtualShelves::Page are pretty obvious and won't cause regressions. I can't imagine that this one small feature would justify rewriting VirtualShelves, but I do agree it could use a rewrite. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38496|0 |1 is obsolete| | Attachment #38497|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38725&action=edit Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 38726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38726&action=edit Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38725|0 |1 is obsolete| | Attachment #38726|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38780&action=edit [PASSED QA] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38781&action=edit [PASSED QA] Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a little worried that this feature is hidden by the fact the print preview doesn't match the actual print out - but this is a good enhancement, no reason to hold it back :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply cleanly on 3.18.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39916&action=edit [v3.18.x] Bug 13986 - Printing a list only prints the results of the page you are viewing The print list button only prints the page you are viewing, and not the entire list. Test Plan: 1) Apply this patch 2) Create a list with enough items that it will paginate 3) Browse to that list, click the 'print list' button 4) Note the entire list prints, not just the visible items Tested in staff client, works as expected. It would be great to have the same for OPAC as well (OPAC still prints first page only). Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Bug 13986 - Implement fix for OPAC Tested wit OPAC, full list is printed. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #22 from Nicole C. Engard <nengard@gmail.com> --- Does the rebased patch apply to 3.18.x? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #23 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- *** Bug 13761 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13986 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton@bywatersolutions.com --- Comment #24 from Barton Chittenden <barton@bywatersolutions.com> --- *** Bug 15372 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org