https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38299 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | CC| |emily.lamancusa@montgomeryc | |ountymd.gov, | |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174109|0 |1 is obsolete| | --- Comment #2 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 174294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174294&action=edit Bug 38385: Improve DB update output on error (UI) When an error occurred during the DB update the UI is not correct. 1. say_success, say_info, etc. show the span tags and are not colored 2. "Everything went okay" shown even if atomic updates failed 3. The same error can be displayed several time (see https://snipboard.io/IGiKgM.jpg) Test plan: Create a new db rev and/or atomic update Have some say_* statement to render messages, and raise an error For instance: say_info( $out, "Use blue for further information" ); try { say_warning( $out, "Use yellow for warning/a call to action" ); $dbh->do(q{}); } catch { say_failure( $out, "Use red for danger/failure" ); $_->rethrow; }; Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38383 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174294|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174410&action=edit Bug 38385: Improve DB update output on error (UI) When an error occurred during the DB update the UI is not correct. 1. say_success, say_info, etc. show the span tags and are not colored 2. "Everything went okay" shown even if atomic updates failed 3. The same error can be displayed several time (see https://snipboard.io/IGiKgM.jpg) Test plan: Create a new db rev and/or atomic update Have some say_* statement to render messages, and raise an error For instance: say_info( $out, "Use blue for further information" ); try { say_warning( $out, "Use yellow for warning/a call to action" ); $dbh->do(q{}); } catch { say_failure( $out, "Use red for danger/failure" ); $_->rethrow; }; Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38383 [Bug 38383] say_info messages in web installer have bad contrast/font color -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38385 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38750 [Bug 38750] installer process not terminating when nothing to do -- You are receiving this mail because: You are watching all bug changes.