[Bug 7957] New: Routing lists: manage several routing list for each subscription, and export them as CSV
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 7957 Assignee: julian.maurice@biblibre.com Summary: Routing lists: manage several routing list for each subscription, and export them as CSV QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Serials Product: Koha This development will allow to create more than one routing list for each subscription. There will be a new page for managing them (create, edit, delete), printing them, and exporting them as CSV. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957
--- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 9259
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9259&action=edit
Routing lists enhancements
- Manage several routing list per subscription
- Export a routing list as CSV
Test plan:
Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'
>From the serials-home.pl page:
- Make a search, in the results list you have a column 'Routing lists'
(if not, consider setting RoutingSerials syspref). If the
subscription doesn't have a routing list, you should have a 'New'
link. Otherwise you have an 'Edit(X)' link, where X is the number of
routing lists.
- Choose a subscription which have no routing lists and click on 'New'
- You are on the routing list creation page. Enter a title for the
routing list and click on 'Save'.
- The routing list has been created and now you are on the routing
list modification page. The behaviour of this page is quite the same
as before. A sensible change is that reordering borrowers doesn't
reload the page each time you make a change.
- Click on 'Save' to finish routing list modifications.
- Now you are on the routing lists management page. You can edit a
routing list by clicking on its title, preview it, export it, and
delete it by clicking on the corresponding link.
- Click on 'Preview'.
- You will be asked to choose a serial. Pick the one you want to print
the routing list for and click on 'Continue'.
- If RoutingListAddReserves is OFF, the routing list is displayed and
you just have to click on 'Print'. If the syspref is ON, you will
have to click on 'Confirm and print', an alert will show telling you
that holds will be placed on the serial you chose. Click 'OK' and
you will be able to print the slip. Now check if the holds have been
placed. (It works only if an item is attached to this serial).
- Go back to the routing lists management page (routinglists.pl) and
click on 'Export'. Download the CSV and check that it contains
correct data.
>From serials-collection.pl page:
- In the serials list, click on 'Print list'.
- You will be asked to choose a routing list. Pick one and click on
'Continue'.
- ... (same behaviour as above)
Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- This patch doesn't apply anymore on HEAD. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Blocks| |2894 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding bug 2894 to this - reading the description of this feature I hope it will fix the broken holds feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9259|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 10973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10973&action=edit Routing lists enhancements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- updatedatabase.pl can't create the two required new tables. I get for example this error message: Can't create table './koha_devel/subscriptionroutinglist.frm' (errno: 150) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- The above error arise because the new table and the existing one don't have the same engine: InnoDB for the former, and MyISAM for the old. This could be a solution: ALTER TABLE borrowers ENGINE = InnoDB; ALTER TABLE subscription ENGINE = InnoDB; But I'm not sure it is good to force to InnoDB tables which may have been in MyISAM for good reasons. Another solution could be to modify updatedatabase.pl to set the new table to the same engine as the related tables. You can get it with: SELECT ENGINE FROM information_schema.TABLES WHERE TABLE_SCHEMA = DATABASE() AND TABLE_NAME = 'subscription' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Frédéric, in kohastructure.sql, the only table which use MyISAM engine is pending_offline_operations. In my databases, subscription and borrowers table both use InnoDB, so why they don't in your database? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> ---
Frédéric, in kohastructure.sql, the only table which use MyISAM engine is pending_offline_operations. In my databases, subscription and borrowers table both use InnoDB, so why they don't in your database?
Good question. Since it's a library currently using Koha database, I'm sure this issue will occur in real life for others. It means that your enhancement won't work at all for some (a lot) of libraries. Maybe this question could be raised on koha-devel list? pointing to this bug. Engine used for all table: SELECT TABLE_NAME, ENGINE FROM information_schema.TABLES WHERE TABLE_SCHEMA = DATABASE() I have a lot of Koha DB mixing MyISAM and InnoDB. Why? I have no clue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #8)
Frédéric, in kohastructure.sql, the only table which use MyISAM engine is pending_offline_operations. In my databases, subscription and borrowers table both use InnoDB, so why they don't in your database?
Good question. Since it's a library currently using Koha database, I'm sure this issue will occur in real life for others. It means that your enhancement won't work at all for some (a lot) of libraries. Maybe this question could be raised on koha-devel list? pointing to this bug.
Engine used for all table:
SELECT TABLE_NAME, ENGINE FROM information_schema.TABLES WHERE TABLE_SCHEMA = DATABASE()
I have a lot of Koha DB mixing MyISAM and InnoDB. Why? I have no clue.
Maybe that's because, during the upgrade from 2.x to 3.0, you missed some message speaking of a problem ? Because the update22to30.pl script update all tables to innoDB. # MOVE all tables TO UTF-8 and innoDB $sth = $dbh->prepare("show table status"); $sth->execute; while ( my $table = $sth->fetchrow_hashref ) { next if $table->{Name} eq 'marc_word'; next if $table->{Name} eq 'marc_subfield_table'; next if $table->{Name} eq 'auth_word'; next if $table->{Name} eq 'auth_subfield_table'; if ($table->{Engine} ne 'InnoDB') { print "moving $table->{Name} to InnoDB\n"; $dbh->do("ALTER TABLE $table->{Name} ENGINE = innodb"); } unless ($table->{Collation} =~ /^utf8/) { print "moving $table->{Name} to utf8\n"; $dbh->do("ALTER TABLE $table->{Name} CONVERT TO CHARACTER SET utf8"); $dbh->do("ALTER TABLE $table->{Name} DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci"); # FIXME : maybe a ALTER TABLE tbl_name CONVERT TO CHARACTER SET utf8 would be better, def char set seems to work fine. If any problem encountered, let's try with convert ! } else { } } If you have such problems in your database, the good option is to write a small script in misc/maintenance, that fixes the problem. It's not the responsibility of this patch, imo, to fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10973|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 13217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13217&action=edit Bug 7957: Routing lists enhancements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Corinne BULAC <corinnebulac@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |corinnebulac@gmail.com --- Comment #11 from Corinne BULAC <corinnebulac@gmail.com> --- Something went wrong ! Applying: Bug 7957: Routing lists enhancements Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Items.pm Auto-merging C4/Serials.pm Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/serials-menu.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt CONFLICT (delete/modify): koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt left in tree. Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Removing serials/reorder_members.pl Removing serials/routing-preview.pl Removing serials/routing.pl Auto-merging serials/serials-collection.pl Auto-merging serials/serials-search.pl Auto-merging serials/subscription-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 7957: Routing lists enhancements When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7957 - Routing lists: manage several routing list for each subscription, and export them as CSV Bug 7957: Routing lists enhancements Apply? [yn] Patch left in /tmp/Bug-7957-Routing-lists-enhancements-8Hq0be.patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957
Julian Maurice <julian.maurice@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #13217|0 |1
is obsolete| |
--- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 16614
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16614&action=edit
Bug 7957: Routing lists enhancements
- Manage several routing list per subscription
- Export a routing list as CSV
Test plan:
Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'
>From the serials-home.pl page:
- Make a search, in the results list you have a column 'Routing lists'
(if not, consider setting RoutingSerials syspref). If the
subscription doesn't have a routing list, you should have a 'New'
link. Otherwise you have an 'Edit(X)' link, where X is the number of
routing lists.
- Choose a subscription which have no routing lists and click on 'New'
- You are on the routing list creation page. Enter a title for the
routing list and click on 'Save'.
- The routing list has been created and now you are on the routing
list modification page. The behaviour of this page is quite the same
as before. A sensible change is that reordering borrowers doesn't
reload the page each time you make a change.
- Click on 'Save' to finish routing list modifications.
- Now you are on the routing lists management page. You can edit a
routing list by clicking on its title, preview it, export it, and
delete it by clicking on the corresponding link.
- Click on 'Preview'.
- You will be asked to choose a serial. Pick the one you want to print
the routing list for and click on 'Continue'.
- If RoutingListAddReserves is OFF, the routing list is displayed and
you just have to click on 'Print'. If the syspref is ON, you will
have to click on 'Confirm and print', an alert will show telling you
that holds will be placed on the serial you chose. Click 'OK' and
you will be able to print the slip. Now check if the holds have been
placed. (It works only if an item is attached to this serial).
- Go back to the routing lists management page (routinglists.pl) and
click on 'Export'. Download the CSV and check that it contains
correct data.
>From serials-collection.pl page:
- In the serials list, click on 'Print list'.
- You will be asked to choose a routing list. Pick one and click on
'Continue'.
- ... (same behaviour as above)
Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #14 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 7957: Routing lists enhancements Using index info to reconstruct a base tree... M C4/Items.pm M C4/Serials.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt M serials/member-search.pl M serials/routing-preview.pl M serials/serials-collection.pl M serials/serials-search.pl M serials/subscription-detail.pl A t/db_dependent/lib/KohaTest/Serials.pm Falling back to patching base and 3-way merge... CONFLICT (modify/delete): t/db_dependent/lib/KohaTest/Serials.pm deleted in HEAD and modified in Bug 7957: Routing lists enhancements. Version Bug 7957: Routing lists enhancements of t/db_dependent/lib/KohaTest/Serials.pm left in tree. Auto-merging serials/subscription-detail.pl Auto-merging serials/serials-search.pl Auto-merging serials/serials-collection.pl Removing serials/routing.pl CONFLICT (modify/delete): serials/routing-preview.pl deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of serials/routing-preview.pl left in tree. Removing serials/reorder_members.pl Auto-merging serials/member-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm Auto-merging C4/Items.pm Patch failed at 0001 Bug 7957: Routing lists enhancements The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957
Julian Maurice <julian.maurice@biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #16614|0 |1
is obsolete| |
--- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> ---
Created attachment 21340
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21340&action=edit
Bug 7957: Routing lists enhancements
- Manage several routing list per subscription
- Export a routing list as CSV
Test plan:
Run the updatedatabase.pl script
Existing routing lists should have been imported in a routing list named
'import'
>From the serials-home.pl page:
- Make a search, in the results list you have a column 'Routing lists'
(if not, consider setting RoutingSerials syspref). If the
subscription doesn't have a routing list, you should have a 'New'
link. Otherwise you have an 'Edit(X)' link, where X is the number of
routing lists.
- Choose a subscription which have no routing lists and click on 'New'
- You are on the routing list creation page. Enter a title for the
routing list and click on 'Save'.
- The routing list has been created and now you are on the routing
list modification page. The behaviour of this page is quite the same
as before. A sensible change is that reordering borrowers doesn't
reload the page each time you make a change.
- Click on 'Save' to finish routing list modifications.
- Now you are on the routing lists management page. You can edit a
routing list by clicking on its title, preview it, export it, and
delete it by clicking on the corresponding link.
- Click on 'Preview'.
- You will be asked to choose a serial. Pick the one you want to print
the routing list for and click on 'Continue'.
- If RoutingListAddReserves is OFF, the routing list is displayed and
you just have to click on 'Print'. If the syspref is ON, you will
have to click on 'Confirm and print', an alert will show telling you
that holds will be placed on the serial you chose. Click 'OK' and
you will be able to print the slip. Now check if the holds have been
placed. (It works only if an item is attached to this serial).
- Go back to the routing lists management page (routinglists.pl) and
click on 'Export'. Download the CSV and check that it contains
correct data.
>From serials-collection.pl page:
- In the serials list, click on 'Print list'.
- You will be asked to choose a routing list. Pick one and click on
'Continue'.
- ... (same behaviour as above)
Try to add and delete routing lists to show if links are correctly
updated in serials-home.pl, serials-collection.pl and
subscription-detail.pl
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot| |2013-09-24 last check this| | --- Comment #17 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot|2013-09-24 00:00:00 |2013-10-25 last check this| | --- Comment #18 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 7957: Routing lists enhancements Using index info to reconstruct a base tree... M C4/Items.pm M C4/Serials.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt M koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt M serials/routing.pl Falling back to patching base and 3-way merge... CONFLICT (modify/delete): serials/routing.pl deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of serials/routing.pl left in tree. Removing serials/routing-preview.pl Removing serials/reorder_members.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt left in tree. Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm Auto-merging C4/Items.pm Patch failed at 0001 Bug 7957: Routing lists enhancements The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21340|0 |1 is obsolete| | --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 22726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22726&action=edit Bug 7957: Routing lists enhancements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #20 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patch. Applying: Bug 7957: Routing lists enhancements Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging serials/subscription-detail.pl Auto-merging serials/serials-search.pl CONFLICT (content): Merge conflict in serials/serials-search.pl Auto-merging serials/serials-collection.pl CONFLICT (modify/delete): serials/routing.pl deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of serials/routing.pl left in tree. CONFLICT (modify/delete): serials/routing-preview.pl deleted in Bug 7957: Routing lists enhancements and modified in HEAD. Version HEAD of serials/routing-preview.pl left in tree. Removing serials/reorder_members.pl Auto-merging serials/member-search.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt Removing koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/serials-toolbar.inc Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Serials.pm Auto-merging C4/Items.pm Failed to merge in the changes. Patch failed at 0001 Bug 7957: Routing lists enhancements So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22726|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35709&action=edit Bug 7957: Routing lists enhancements Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Julian. I've applied the patch against master 3.19.00.010 head 13675. On /cgi-bin/koha/serials/subscription-detail.pl I've selected the "Create routing list" [/ "Edit routing list"] at the left of the page. I've received the "Create routing list" [/ "Routing list for ...."] page. In both the 2 cases, then I've selected : "Serial collection" at the left of this page. I saw: <h1>Software error:</h1> <pre>Undefined subroutine &main::check_routing called at /[....]/serials/serials-collection.pl line 132. </pre> So I pass the patch to "Failed QA" status. NB-1) The patch needed a trivial rebase. NB-2) Step 1: Make a search, in the results list you have a column 'Routing lists' (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New' link. Otherwise you have an 'Edit(X)' link, where X is the number of routing lists. RoutingSerials "Use"/"Don't use" is OK as required. But at present the "column" is an "Actions". Could you update the test plan please? [A numbered indentation would be very helpful to me in this long test plan.] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35709|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35801&action=edit Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import'
From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Routing lists' (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New' link. Otherwise you have an 'Edit(X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data.
From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above)
Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl (rebased and test plan updated) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35802&action=edit Bug 7957: Remove uses of check_routing which doesn't exist anymore Also remove a unit tests about C4::Serials::addroutingmember which also no longer exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35801|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35803&action=edit Bug 7957: Routing lists enhancements - Manage several routing list per subscription - Export a routing list as CSV Test plan: Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import'
From the serials-home.pl page: 1 Make a search, in the results list you have a column 'Actions' that should contain a "New/Edit routing list" link" (if not, consider setting RoutingSerials syspref). If the subscription doesn't have a routing list, you should have a 'New routing list' link. Otherwise you have an 'Edit routing lists (X)' link, where X is the number of routing lists. 2 Choose a subscription which have no routing lists and click on 'New routing list' 3 You are on the routing list creation page. Enter a title for the routing list and click on 'Save'. 4 The routing list has been created and now you are on the routing list modification page. The behaviour of this page is quite the same as before. A sensible change is that reordering borrowers doesn't reload the page each time you make a change. 5 Click on 'Save' to finish routing list modifications. 6 Now you are on the routing lists management page. You can edit a routing list by clicking on its title, preview it, export it, and delete it by clicking on the corresponding link. 7 Click on 'Preview'. 8 You will be asked to choose a serial. Pick the one you want to print the routing list for and click on 'Continue'. 9 If RoutingListAddReserves is OFF, the routing list is displayed and you just have to click on 'Print'. If the syspref is ON, you will have to click on 'Confirm and print', an alert will show telling you that holds will be placed on the serial you chose. Click 'OK' and you will be able to print the slip. Now check if the holds have been placed. (It works only if an item is attached to this serial). 10 Go back to the routing lists management page (routinglists.pl) and click on 'Export'. Download the CSV and check that it contains correct data.
From serials-collection.pl page: 11 In the serials list, click on 'Print list'. 12 You will be asked to choose a routing list. Pick one and click on 'Continue'. 13 ... (same behaviour as above)
Try to add and delete routing lists to show if links are correctly updated in serials-home.pl, serials-collection.pl and subscription-detail.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35802|0 |1 is obsolete| | --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35804&action=edit Bug 7957: Remove uses of check_routing which doesn't exist anymore Also remove a unit tests about C4::Serials::addroutingmember which also no longer exists -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Paola Rossi <paola.rossi@cineca.it> --- Thank you very much, Julian. I've applied the patches against master 3.19.00.010 head 13240. The sw error in comment #22 is OK! About:
Run the updatedatabase.pl script Existing routing lists should have been imported in a routing list named 'import'
All existing routing lists were named "import", as required. But the note field of the existing RLs were all lost. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #28 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35842&action=edit Bug 7957: Retrieve routing notes from serial table and remove serial.routingnotes column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #29 from Julian Maurice <julian.maurice@biblibre.com> --- I was not aware of this note field. With this patch it should be retrieved during the updatedatabase process. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Julian. I've applied the 3 patches against master 3.19.00.010. The existing imported-RLs' notes were present, as expected. On master, on Patrons the tag “Routing lists” of a patron lists the subscriptions’ RL-s the patron-borrower is in. On the contrary, after having applied the patches, the tag “Routing lists” of a patron lists no (neither new nor imported) RL-s the patron is in: 0 Subscription routing lists Patron does not belong to any subscription routing lists. I think this could be an error. For now I pass the patch to "Failed QA". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35860&action=edit Bug 7957: Fix members/routing-lists.pl page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Thanks for your comments Paola, I didn't even know this page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Julian. [And the name of each RL is shown in the RL-s' table, added against master!] I was trying to "Add a borrower" to a RL. On /cgi-bin/koha/serials/member-search.pl, I: A) have selected a Library and a Category, and these input values have been crossed in AND [OK]: Library AND Category B) have selected a Library, a Category and a Name, and these input values have been crossed in (?): Name OR (Library AND Category) Name OR Library Name OR Category while I was expecting Name AND Library AND Category Name AND Library Name AND Category I think this could be an error. So I pass to "Failed QA" status. NB-1) On /cgi-bin/koha/serials/member-search.pl, I selected a library, and the library [code] appeared in the table result, and IMO this is a benefit for the user. On the contrary, if I selected a category, the category didn't appear in the table result. Perhaps it could be added? NB-2) On /cgi-bin/koha/serials/routinglists.pl, the RL is shown to be: Routing lists for X, where X is the serial-bibliographic-record's title. But the RL is about 1 subscription, and a serial-biblio-record can have some subscriptions. In other parts of koha [serials/serials-collection.pl], koha shows the serial-bibliographic-record title and the "Subscription num." #numbercode's link. Perhaps it could be helpful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from Julian Maurice <julian.maurice@biblibre.com> --- This search generates a quite long SQL query: http://pastebin.com/qYULAHsm where the search is done on firstname, surname, email, othernames and cardnumber. But basically you're right, it does something like (Name OR (Library AND Category)) I don't know if this is intended or not, and as the behaviour is the same as master, I suggest to open a new bug for that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35803|0 |1 is obsolete| | --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35872&action=edit [SIGNED OFF] Bug 7957: Routing lists enhancements I've applied the 4 patches against master 3.19.00.010 head 13240. Everything is OK. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35804|0 |1 is obsolete| | --- Comment #36 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35873&action=edit [SIGNED OFF] Bug 7957: Remove uses of check_routing which doesn't exist anymore -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35842|0 |1 is obsolete| | --- Comment #37 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35874&action=edit [SIGNED OFF] Bug 7957: Retrieve routing notes from serial table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35860|0 |1 is obsolete| | --- Comment #38 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 35875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35875&action=edit [SIGNED OFF] Bug 7957: Fix members/routing-lists.pl page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13716 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #39 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Julian Maurice from comment #34)
This search generates a quite long SQL query: http://pastebin.com/qYULAHsm where the search is done on firstname, surname, email, othernames and cardnumber. But basically you're right, it does something like (Name OR (Library AND Category)) I don't know if this is intended or not, and as the behaviour is the same as master, I suggest to open a new bug for that.
I opened the new bug 13716 on this topic. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know this is old code, so not sure about DBIX or use of the new Koha Object, but quite sure we should have tests! These patches only remove a few tests, but none are added for the new module. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #41 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 38425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38425&action=edit Bug 7957: Add unit tests for new subroutines -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Julian, please rebase, I will try to have a look. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35872|0 |1 is obsolete| | Attachment #35873|0 |1 is obsolete| | Attachment #35874|0 |1 is obsolete| | Attachment #35875|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41762&action=edit Bug 7957: Routing lists enhancements Rebased on master Squashed the first four patches + moved the updatedatabase part to atomicupdate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38425|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41763&action=edit Bug 7957: Add unit tests for new subroutines Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #45 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 41764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41764&action=edit Bug 7957: Redirect after creating a new routing list This avoids creating the same list multiple times when reloading the page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- On updating the DB, I got several lines of this type: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`subscriptionrouting`, CONSTRAINT `subscriptionrouting_ibfk_2` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE) at /home/koha/src/installer/data/mysql/atomicupdate/bug_7957.perl line 62. DBD::mysql::st execute failed: Duplicate entry '2-7363' for key 'PRIMARY' at /home/koha/src/installer/data/mysql/atomicupdate/bug_7957.perl line 62. Any ideas of why? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- MariaDB [koha]> select * from subscriptionroutinglist; +-----------+----------------+---------+----------------+ | routingid | borrowernumber | ranking | subscriptionid | +-----------+----------------+---------+----------------+ [SKIP] | 195 | 7874 | 38 | 2 | | 196 | 7874 | 39 | 2 | [SKIP] I don't know if it's a DB data error or if it comes from the updatedb entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #48 from Julian Maurice <julian.maurice@biblibre.com> --- It seems you have a problem with your database. On master, subscriptionroutinglist has UNIQUE (`subscriptionid`, `borrowernumber`) so you shouldn't be able to have 2 rows with same borrowernumber and subscriptionid. Also, subscriptionroutinglist has a foreign key constraint on borrowernumber; the "Cannot add or update a child row" error should not happen I could "hide" those errors by adding IGNORE to the INSERT query, but I don't know if it's the best thing to do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9809 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Conflicts with bug 9809. Don't forget to uptade AddReserve calls. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41762|0 |1 is obsolete| | --- Comment #50 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 42427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42427&action=edit Bug 7957: Routing lists enhancements Rebased on master Call to AddReserve updated -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41763|0 |1 is obsolete| | --- Comment #51 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 42428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42428&action=edit Bug 7957: Add unit tests for new subroutines Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41764|0 |1 is obsolete| | --- Comment #52 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 42429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42429&action=edit Bug 7957: Redirect after creating a new routing list Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org