[Bug 43307] New: Migrate cataloguing/moveitem.tt to use api-client.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Bug ID: 43307 Summary: Migrate cataloguing/moveitem.tt to use api-client.js Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 34451 Target Milestone: --- cataloguing/moveitem.tt uses raw jQuery.ajax() for DELETE calls to /api/v1/biblios/.... These need to be migrated to api-client.js for proper CSRF token handling (bug 34451). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34451 Depends on|34451 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203761&action=edit Bug 43307: Migrate cataloguing/moveitem.tt to use api-client.js This patch replaces the raw jQuery.ajax() DELETE call for deleting a biblio record with the api-client.js pattern. Changes: - Add biblios.delete method to BiblioAPIClient - Register BiblioAPIClient in the main api-client.js - Replace $.ajax DELETE in moveitem.tt with APIClient.biblio call Test plan: 1. Apply patch 2. Go to Cataloging > Move items 3. Move items from one record to another until source is empty 4. Click "Delete this record" => SUCCESS: Record deleted, success message shown 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203789&action=edit Bug 43307: Migrate cataloguing/moveitem.tt to use api-client.js This patch replaces the raw jQuery.ajax() DELETE call for deleting a biblio record with the api-client.js pattern. Changes: - Add biblios.delete method to BiblioAPIClient - Register BiblioAPIClient in the main api-client.js - Replace $.ajax DELETE in moveitem.tt with APIClient.biblio call Test plan: 1. Apply patch 2. Go to Cataloging > Move items 3. Move items from one record to another until source is empty 4. Click "Delete this record" => SUCCESS: Record deleted, success message shown 5. Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203789|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43307 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 206511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206511&action=edit Bug 43307: Migrate cataloguing/moveitem.tt to use api-client.js This patch replaces the raw jQuery.ajax() DELETE call for deleting a biblio record with the api-client.js pattern. Changes: - Add biblios.delete method to BiblioAPIClient - Register BiblioAPIClient in the main api-client.js - Replace $.ajax DELETE in moveitem.tt with APIClient.biblio call Test plan: 1. Apply patch 2. Go to Cataloging > Move items 3. Move items from one record to another until source is empty 4. Click "Delete this record" => SUCCESS: Record deleted, success message shown 5. Sign off :-D Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org