[Bug 29228] New: Use Flatpickr on offline circulation page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Bug ID: 29228 Summary: Use Flatpickr on offline circulation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 28376 The offline circulation page wasn't included when Bug 28937 was submitted. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Replace obsolete jquery-ui-timepicker-addon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29239 [Bug 29239] [OMNIBUS] Replace jQueryUI's timepicker with flatpickr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22671, 29255 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 [Bug 22671] Built-in offline circulation applicationCache errors https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 [Bug 29255] Built-in offline circulation broken with SQL error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 127095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127095&action=edit Bug 29228: Use Flatpickr on offline circulation page This patch replaces the use of jQueryUI datepicker on the built-in offline circulation page, where it was used for the "Specify due date" date-time picker as well as for formatting datetime values for display. To test, apply the patch and go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click "Download records." - Submit a card number for a patron who has multiple items checked out. - In the table of previous checkouts, confirm that dates in the "Date due" and "Checked out on" columns are formatted according to your TimeFormat and DateFormat system preferences. - When checking out to a patron with fines, open the fines tab and submit an amount in payment. The table of payments should include a correctly-formatted datetime. - Test that the "Specify due date" date picker works correctly and that checkouts show the correct date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22671 | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm removing the dependency on Bug 22671 because it's not strictly necessary, it just makes it easier to identify whether you're testing in a browser which will work. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22671 [Bug 22671] Warn the user in offline circulation if applicationCache isn't supported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127095|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129986&action=edit Bug 29228: Use Flatpickr on offline circulation page This patch replaces the use of jQueryUI datepicker on the built-in offline circulation page, where it was used for the "Specify due date" date-time picker as well as for formatting datetime values for display. To test, apply the patch and go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click "Download records." - Submit a card number for a patron who has multiple items checked out. - In the table of previous checkouts, confirm that dates in the "Date due" and "Checked out on" columns are formatted according to your TimeFormat and DateFormat system preferences. - When checking out to a patron with fines, open the fines tab and submit an amount in payment. The table of payments should include a correctly-formatted datetime. - Test that the "Specify due date" date picker works correctly and that checkouts show the correct date. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works nicely, sorry it took me so long to get around to.. it kept falling off the list. Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Bug 29228 depends on bug 29255, which changed state. Bug 29255 Summary: Built-in offline circulation broken with SQL error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29255 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28376 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28376 [Bug 28376] Flatpickr introduction for datetime picker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30011 [Bug 30011] Upgrade jQueryUI to 1.13.1 in the OPAC and staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The download records step only works with turned off strict SQL mode, I've filed: Bug 30369 - Downloading records for inbuilt offline circulation fails with strict SQL setting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129986|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132271&action=edit Bug 29228: Use Flatpickr on offline circulation page This patch replaces the use of jQueryUI datepicker on the built-in offline circulation page, where it was used for the "Specify due date" date-time picker as well as for formatting datetime values for display. To test, apply the patch and go to Circulation -> Built-in offline circulation interface. - Click "Synchronize." - Click "Download records." - Submit a card number for a patron who has multiple items checked out. - In the table of previous checkouts, confirm that dates in the "Date due" and "Checked out on" columns are formatted according to your TimeFormat and DateFormat system preferences. - When checking out to a patron with fines, open the fines tab and submit an amount in payment. The table of payments should include a correctly-formatted datetime. - Test that the "Specify due date" date picker works correctly and that checkouts show the correct date. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29228 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org