[Bug 34773] New: Improve translation of title tags: Cataloging tools
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Bug ID: 34773 Summary: Improve translation of title tags: Cataloging tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify cataloging tool templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155621&action=edit Bug 34773: Improve translation of title tags: Cataloging tools This patch modifies cataloging tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. Note that stockrotation.pl has been modified so that rota information is available to the template in more cases for the purpose of showing that information in navigation and headings. To test, apply the patch and go to Cataloging. Test each page and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Stage records for import - Main page - Upload file -> Stage for import - Manage staged records - Main page - Batch details - Import batch - Batch item modification and batch item deletion - Main page - Submit batch - Save - Batch record modification - Main page - Submit batch - Modify selected - Batch record deletion - Main page - Submit batch - Delete selected - MARC modification templates - Main page - Edit actions for a template - Item modifications by age - Main page - Add rules - Stock rotation - Main page - New rota - Edit rota - Manage stages for rota - New stage - Edit stage - Manage items for rota - Add items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155621|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155622&action=edit Bug 34773: Improve translation of title tags: Cataloging tools This patch modifies cataloging tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. Note that stockrotation.pl has been modified so that rota information is available to the template in more cases for the purpose of showing that information in navigation and headings. To test, apply the patch and go to Cataloging. Test each page and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Export catalog data - Stage records for import - Main page - Upload file -> Stage for import - Manage staged records - Main page - Batch details - Import batch - Batch item modification and batch item deletion - Main page - Submit batch - Save - Batch record modification - Main page - Submit batch - Modify selected - Batch record deletion - Main page - Submit batch - Delete selected - MARC modification templates - Main page - Edit actions for a template - Item modifications by age - Main page - Add rules - Stock rotation - Main page - New rota - Edit rota - Manage stages for rota - New stage - Edit stage - Manage items for rota - Add items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155668&action=edit Bug 34773: (follow-up) Missed inventory template Test Cataloging -> Inventory and the results page after submitting a batch of barcodes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155668|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155710&action=edit Bug 34773: (follow-up) Missed templates This patch fixes three templates I missed the first time around: Inventory, MARC diff view, and Upload local cover images. - Cataloging -> Inventory and the results page after submitting a batch of barcodes. - Cataloging -> Manage staged records -> Select a batch which includes record matches: Click the "View" link in the "Diff" column for a record which has a match. - Cataloging -> Upload local cover image (with LocalCoverImages enabled) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155622|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 158295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158295&action=edit Bug 34773: Improve translation of title tags: Cataloging tools This patch modifies cataloging tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. Note that stockrotation.pl has been modified so that rota information is available to the template in more cases for the purpose of showing that information in navigation and headings. To test, apply the patch and go to Cataloging. Test each page and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Export catalog data - Stage records for import - Main page - Upload file -> Stage for import - Manage staged records - Main page - Batch details - Import batch - Batch item modification and batch item deletion - Main page - Submit batch - Save - Batch record modification - Main page - Submit batch - Modify selected - Batch record deletion - Main page - Submit batch - Delete selected - MARC modification templates - Main page - Edit actions for a template - Item modifications by age - Main page - Add rules - Stock rotation - Main page - New rota - Edit rota - Manage stages for rota - New stage - Edit stage - Manage items for rota - Add items Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155710|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 158296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158296&action=edit Bug 34773: (follow-up) Missed templates This patch fixes three templates I missed the first time around: Inventory, MARC diff view, and Upload local cover images. - Cataloging -> Inventory and the results page after submitting a batch of barcodes. - Cataloging -> Manage staged records -> Select a batch which includes record matches: Click the "View" link in the "Diff" column for a record which has a match. - Cataloging -> Upload local cover image (with LocalCoverImages enabled) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes and comments (using KTD): 1. I used one browser (in this case Chromium with clear history, cache, etc.) to walk through all the things listed, then after applying the patch walked through using another browser (in this Firefox Developer Edition with history, cache, etc., cleared). 2. Noted for another bug? Batch item modification - Job has been enqueued page - there are two "Return to batch item modification" links. One is a link, the other is a white button with a tick 3. Stock rotation - maybe delete stage requires an update? 2.1 Enable StockRotation system preference 2.2 When deleting a stage, the breadcrumb changes to Cataloging > Stock rotation, with a message "Are you sure you wnat to delete this stage?" (page title is Stock rotation > Cataloging > Koha). 2.3 Should this be similar to editing? (Cataloging > Stick rotation > Manage stages for "Name of rota' > Modify <name> stage) 4. Other cataloging areas taken care of by other bugs: - Catalog concerns (CatalogConcerns system preference) - Bug 33916 - Label creator, Barcode image generator, Quick spine label creator - Bug 33916 - Advanced editor, new record, and new from Z39.50/SRU (?) - Bug 33912 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158295|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158440&action=edit Bug 34773: Improve translation of title tags: Cataloging tools This patch modifies cataloging tools templates so that title tags can be more easily translated. The patch also makes some modifications to titles, breadcrumb navigation, and page headers in order to make them more consistent with each other and with other similar pages. Note that stockrotation.pl has been modified so that rota information is available to the template in more cases for the purpose of showing that information in navigation and headings. To test, apply the patch and go to Cataloging. Test each page and each variation of the page to confirm that titles, breadcrumbs, and page headers look correct. - Export catalog data - Stage records for import - Main page - Upload file -> Stage for import - Manage staged records - Main page - Batch details - Import batch - Batch item modification and batch item deletion - Main page - Submit batch - Save - Batch record modification - Main page - Submit batch - Modify selected - Batch record deletion - Main page - Submit batch - Delete selected - MARC modification templates - Main page - Edit actions for a template - Item modifications by age - Main page - Add rules - Stock rotation - Main page - New rota - Edit rota - Manage stages for rota - New stage - Edit stage - Manage items for rota - Add items Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158296|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158441&action=edit Bug 34773: (follow-up) Missed templates This patch fixes three templates I missed the first time around: Inventory, MARC diff view, and Upload local cover images. - Cataloging -> Inventory and the results page after submitting a batch of barcodes. - Cataloging -> Manage staged records -> Select a batch which includes record matches: Click the "View" link in the "Diff" column for a record which has a match. - Cataloging -> Upload local cover image (with LocalCoverImages enabled) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34773 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org