[Bug 9711] New: OPACPopupAuthorsSearch ugly in CSSR
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Bug ID: 9711 Summary: OPACPopupAuthorsSearch ugly in CSSR Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Depends on: 5888 Created attachment 15665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15665&action=edit cssr and OPACPopupAuthorsSearch When you have OPACPopupAuthorsSearch set to show the checkboxes in CCSR it looks horrible - see attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 15666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15666&action=edit prog and OPACPopupAuthorsSearch Looks good -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15676&action=edit Bug 9711: Add css style for OPACPopupAuthorsSearch Bug 5888 introduces a new syspref OPACPopupAuthorsSearch. If enabled, a popup is displayed on the OPAC detail page. This development does not add the css for the ccsr theme. Test plan: Enable the OPACPopupAuthorsSearch. Check that the appearance is the same of prog and ccsr themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15676|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 15679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15679&action=edit [SIGNED-OFF] Bug 9711: Add css style for OPACPopupAuthorsSearch Bug 5888 introduces a new syspref OPACPopupAuthorsSearch. If enabled, a popup is displayed on the OPAC detail page. This development does not add the css for the ccsr theme. Test plan: Enable the OPACPopupAuthorsSearch. Check that the appearance is the same of prog and ccsr themes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested on several authorities (authors, subjects, etc) works as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It seems I can't get this to work with my data - no checkboxes appear. Can I get some more information about the new pref and about the conditions for the checkboxes to appear? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #4)
It seems I can't get this to work with my data - no checkboxes appear. Can I get some more information about the new pref and about the conditions for the checkboxes to appear?
Katrin, you must have Additional authors and/or Subject(s) for your record. Checkboxes appear when clicking on one of them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I had checked records with more than one other shown in the by line - is there more to it? Which fields? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- It is not the "by" line but the "Additional authors:" and "Subject(s):" lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I can't get this to feature to show up for me. If you want me to look at it again please provide a detailed step by step test plan and information on how the MARC record has to look like. I am removing myself as QA contact - maybe someone else has the right data to QA this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Katrin, The "additionnal authors" links are filled with the result of the C4::Biblio::GetMarcAuthors routine. So for UNIMARC, with fields 700 to 712 (without $3 et $5) and for others MARC flavors fields are 700 to 720. For subjects: UNIMARC 600 to 611 without $2, $3, $4, $5 ; others MARC flavors: 600 to 699 (without $2 for MARC21) If you fill a least one of these fields, you should see the feature. I can provide an export of one of my notices if you have an UNIMARC install. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
Confirm layout is ok/broken in OPAC
Confirm layout is ok/broken in OPAC
Confirm layout is ok/broken in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15679|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16129&action=edit [PASSED QA] Bug 9711: Add css style for OPACPopupAuthorsSearch Bug 5888 introduces a new syspref OPACPopupAuthorsSearch. If enabled, a popup is displayed on the OPAC detail page. This development does not add the css for the ccsr theme. Test plan: Enable the OPACPopupAuthorsSearch. Check that the appearance is the same of prog and ccsr themes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested on several authorities (authors, subjects, etc) works as expected Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan: 1) Switch to CCSR theme 2) Turn off XSLT views (leaving prefs empty) 3) Turn on OPACPopupAuthorsSearch 4) Switch back to prog theme 5) Switch off OPACPopupAuthorsSearch 6) Switch back to CCSR
Confirm layout is ok/broken in OPAC
Done. Note: Feature only works with normal view (no XSLT) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9711 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org