[Bug 18762] New: Some tests are noisy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Bug ID: 18762 Summary: Some tests are noisy Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: gmcharlt@gmail.com xt/author/valid-templates.t .. 32/? Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 785. Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt line 785. xt/author/valid-templates.t .. 47/? Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-detail.tt line 49. xt/author/valid-templates.t .. 59/? # excluding template /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc because it cannot stand on its own # excluding template /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc because it cannot stand on its own xt/author/valid-templates.t .. 150/? Argument "" isn't numeric in multiplication (*) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt line 356. [SKIP CGI warnings] Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt line 134. Argument "" isn't numeric in numeric gt (>) at /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt line 134. t/db_dependent/Search/History.t .. 1/27 DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. t/db_dependent/Search.t .. The syspref casAuthentication was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref casLogout was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref casServerUrl was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. The syspref template was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 140. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64114&action=edit Bug 18762: Remove warnings from xt/author/valid-templates.t Test plan: Read the changes and make sure they make sense -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64115&action=edit Bug 18762: Remove a warning from History.t Test plan: prove t/db_dependent/Search/History.t should not display any warnings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64116&action=edit Bug 18762: Remove some warnings from Search.t Note that some are caused by CGI, see bug 18632 Test plan: Confirm there are less warnings with this patch applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64116|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64117&action=edit Bug 18762: Remove some warnings from Search.t Note that some are caused by CGI, see bug 18633 Test plan: Confirm there are less warnings with this patch applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18633 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 64170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64170&action=edit Bug 18762: Catch noisy conditions in t/db_dependent/Search.t Seems that the grs1 case for ti:punctuation generates a warning, while the dom case does not. This tweak catches both. before patch: noisy. after patch: no unexpected output. run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- And with this patch, I believe the only noise generated are the CGI related issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu --- Comment #7 from Lee Jamison <ldjamison@marywood.edu> --- Running 'prove -v xt/author/valid-templates.t' outputs the following warnings (I included surrounding passed tests to indicate where in the test the warnings appear: ok 228 - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt CGI::param called in list context from package Template::Document line 41, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 43, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 41, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 43, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 41, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 43, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 41, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 43, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 121, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 122, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 123, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 124, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 466, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. CGI::param called in list context from package Template::Document line 471, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. k 229 - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt ok 230 - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_csv.tt CGI::param called in list context from package Template::Document line 3, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. ok 231 - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch_json.tt ok 599 - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt CGI::param called in list context from package Template::Document line 47, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436. ok 600 - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt Everything passes so I COULD sign off on it but before I do I wanted to make sure the CGI::Param warning wouldn't cause a security/architectural concern. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Lee Jamison from comment #7) [snip]
Everything passes so I COULD sign off on it but before I do I wanted to make sure the CGI::Param warning wouldn't cause a security/architectural concern.
The CGI::Param is beyond the scope of this bug, and is dealt with on other bugs such as bug 18633. The CGI::Param issues are more difficult to narrow down as well. You will note also on comment #0 that JD expressly said, "[SKIP CGI warnings]". If all the other bugs, except the CGI::Param ones are eliminated, then I would recommend a sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #9 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64175&action=edit [SIGNED OFF] Bug 18762: Catch noisy Search.t Seems that the grs1 case for ti:punctuation generates a warning, while the dom case does not. This tweak catches both. before patch: noisy. after patch: no unexpected output. run koha qa test tools Signed-off-by: Lee Jamison <ldjamison@marywood.edu> I ran reset_all in kohadevbox. This patch clears up the extra noise correctly now and passes QA tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64170|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 64170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64170 Bug 18762: Catch noisy conditions in t/db_dependent/Search.t Forgot to obsolete this patch that was signed off. This is why the kohadevbox [SIGNED OFF] logic may get in the way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- It's late here, and I noticed that Lee only signed off the last one. I've tested this as well, and would sign everything off, if a QA'r just wants to go ahead and fake my sign off in the midst of QA'ing. If I remember to check later, I'll sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #12 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64232&action=edit Bug 18656 - Require confirmation of deletion of files from patron record This patch adds a JavaScript confirm to the deletion of files. It also styles the file deletion link as a Bootstrap button. To test, apply the patch and open the "Files" page for a patron who has files attached. - Verify that clicking any "delete" link prompts for a confirmation. - Verify that confirming the dialog triggers the deletion of the correct file. - Verify that canceling the confirmation dialog aborts the deletion. - Confirm that the "Delete" button looks correct. Signed-off-by: David Roberts <david.roberts@ptfs-europe.com> Revision for QA: Replaced '.click(function' with '.on("click",function' Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64175|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64170|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64114|0 |1 is obsolete| | Attachment #64115|0 |1 is obsolete| | Attachment #64117|0 |1 is obsolete| | Attachment #64170|0 |1 is obsolete| | --- Comment #13 from Lee Jamison <ldjamison@marywood.edu> --- Created attachment 64234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64234&action=edit [SIGNED OFF] Bug 18762: Warnings valid-templates.t Test plan: Read the changes and make sure they make sense Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Changes make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64114|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64115|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64116|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64170|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to M. Tompsett from comment #5)
Created attachment 64170 [details] [review] Bug 18762: Catch noisy conditions in t/db_dependent/Search.t
Seems that the grs1 case for ti:punctuation generates a warning, while the dom case does not. This tweak catches both.
before patch: noisy. after patch: no unexpected output. run koha qa test tools
Tomas, could you take a look at this last patch please? No idea why it is warning now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64114|0 |1 is obsolete| | Attachment #64115|0 |1 is obsolete| | Attachment #64116|0 |1 is obsolete| | Attachment #64170|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64294&action=edit Bug 18762: Remove warnings from xt/author/valid-templates.t Test plan: Read the changes and make sure they make sense Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64295&action=edit Bug 18762: Remove a warning from History.t Test plan: prove t/db_dependent/Search/History.t should not display any warnings Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 64296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64296&action=edit Bug 18762: Remove some warnings from Search.t Note that some are caused by CGI, see bug 18632 Test plan: Confirm there are less warnings with this patch applied Signed-off-by: Lee Jamison <ldjamison@marywood.edu> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Added the signed-off-by lines. Mark I removed your patch, I am not sure if the warning should be displayed. I do not have time to dig into the problem right now and would like to see the other patches pushed. Will see that later. Skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #20 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Just to be clear on TT syntax. There is a change : -[% IF fines > 0 %] +[% IF fines and fines > 0 %] But also : - [% IF count > 0 %] + [% IF count %] Why not using the same compact [% IF var %] ? Is it false with undef and "0" right ? --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes it is the same. --- Comment #22 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #21)
Yes it is the same.
Ok thanks a lot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #23 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org