https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- There are also controls to change the manager in bulk from the main purchase suggestion page. I can't get that to work, either. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24819 Status|NEW |ASSIGNED --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is caused by bug 24819. It has been pushed 1 month after bug 23590. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 [Bug 24819] Add ability for librarians to choose a patron when entering a purchase suggestion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112836&action=edit Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This does allow me to save changes to the manager of a purchase suggestion. I've not seen any notices generated as I do so. My two demo users do both have email addresses and the notice "NOTIFY_MANAGER" exists. Am I missing something there? Is the manager of a purchase suggestion meant to always default to whoever last edited it? If I edit an existing suggestion with another user as the manager, Koha will set me as the manger unless I remember to click to tell it not to. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112836|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 112842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112842&action=edit Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Andrew Fuerste-Henry from comment #8)

I *was* missing something! there's a checkbox!

Manager changed successfully through both edit and batch interfaces. Notice sent successfully. I'm still a little torn about defaulting the changing the manager each time you edit, but will wait to see what users think.

I'm sure I've seen another bug regarding always setting the manager to the last person to update the suggestion.. I can't remember which way the bug was pushing for and can't find the bug now though :(. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I don't manage to change the manager to another user than the current one. Followed Andrew's steps. Jonathan's are about changing the 'suggester' so I'm confused. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Just tested this again, successfully. Updated test plan: To test: 1- make sure you have at least 2 patrons with purchase suggestion permissions and email addresses 2- open a new or existing purchase suggestion 3- in the Suggestion Management section, click the Select Manager link 4- in the patron search popup, search for and select a staff member with suggestion permissions 5- on the suggestion, click the "Notifiy Manager" checkbox 6- save your suggestion 7- on suggestion.pl, confirm your suggestion shows your selected staff member for Managed By 8- confirm your staff member received a notice 9- on suggestion.pl, use the checkboxes to select your suggestion and any number of additional suggestions 10- click Select Manager in the Update Manger box underneath the suggestions table 11- again, use the patron search popup to pick someone 12- click Submit to make your change 13- confirm the suggestions table reflects your change (there is not yet a way to send a notice for batch changes) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 112920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112920&action=edit Bug 26738: (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113746&action=edit Bug 26738: [20.05.x] (bug 24819 follow-up) Fix manager selection Bug 23590 added a new feature to select the manager of a suggestion. One month later bug 24819 added the ability to pick the suggester. This second patchset broke the manager selection. This patch simplifies the way the suggester is selected, using the generic way and mimicking what is done for the manager. Test plan: - create a new purchase suggestion from within acquisitions (suggestion.pl?op=add) - click "select manager," search for user, click Select - see that the user you just selected shows under "Created by," - see that "Managed by" still says "You" - modify the suggester - save your suggestion => Everything is saved correctly QA will test the permission alert: Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage" Edit the suggestion, select a manager, pick a patron in the list who does not have sufficient permissions, save => you get the alert Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Bug 26738: (QA follow-up) Add missing filter Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |aleisha@catalyst.net.nz --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- missing dependencies, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Bug 26738 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.