[Bug 42421] New: Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Bug ID: 42421 Summary: Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk It can be useful to use pull requests for internal development before community submission. The github actions close-pr.yml closes all pull requests automatically ). This should only happen for the official community GitHub repo. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40027 Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40027 [Bug 40027] Use GitHub workflow to automatically close PRs opened on the Koha repo there -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 197792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197792&action=edit Bug 42421 - Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo It can be useful to use pull requests for internal development before community submission. The github actions close-pr.yml closes all pull requests automatically ). This should only happen for the official community GitHub repo. Test Plan: 1) Fork the Koha community repo on GitHub 2) Make a pull request to your repo 3) Note it is closed automatically 4) Apply this patch 5) Make another pull request 6) Note pull request stays open! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 197793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197793&action=edit Bug 42421: Remove checkout from step, it is not used Patch from commit 79524d8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 197794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197794&action=edit Bug 42421: Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo It can be useful to use pull requests for internal development before community submission. The github actions close-pr.yml closes all pull requests automatically ). This should only happen for the official community GitHub repo. Test Plan: 1) Fork the Koha community repo on GitHub 2) Make a pull request to your repo 3) Note it is closed automatically 4) Apply this patch 5) Make another pull request 6) Note pull request stays open! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 197795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197795&action=edit Bug 42421: Remove checkout from step, it is not used Patch from commit 3cb3b53 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197795|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #5 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 197797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197797&action=edit Bug 42421: Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo It can be useful to use pull requests for internal development before community submission. The github actions close-pr.yml closes all pull requests automatically ). This should only happen for the official community GitHub repo. Test Plan: 1) Fork the Koha community repo on GitHub 2) Make a pull request to your repo 3) Note it is closed automatically 4) Apply this patch 5) Push this patched branch to your GitHub repo 6) Set this branch as your default branch for your GitHub repo 5) Make another pull request 6) Note pull request stays open! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 197798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197798&action=edit Bug 42421: Remove checkout from step, it is not used Patch from commit d8d999e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu --- Comment #7 from Eric Phetteplace <ephetteplace@cca.edu> --- I'll sign off in a moment as this worked for me: - Closed automatically https://github.com/phette23/Koha/pull/3 - Stayed open https://github.com/phette23/Koha/pull/5 Note about testing on GitHub; the main branch needs to have the workflow changes for this to work, even if your PR is not targeting the main branch, at least that was my experience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197797|0 |1 is obsolete| | Attachment #197798|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #8 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 198479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198479&action=edit Bug 42421: Only run GitHub Actions for closing pull requests (close-pr.yml) on the community repo It can be useful to use pull requests for internal development before community submission. The github actions close-pr.yml closes all pull requests automatically ). This should only happen for the official community GitHub repo. Test Plan: 1) Fork the Koha community repo on GitHub 2) Make a pull request to your repo 3) Note it is closed automatically 4) Apply this patch 5) Push this patched branch to your GitHub repo 6) Set this branch as your default branch for your GitHub repo 5) Make another pull request 6) Note pull request stays open! Signed-off-by: Eric Phetteplace <phette23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 --- Comment #9 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 198480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198480&action=edit Bug 42421: Remove checkout from step, it is not used Signed-off-by: Eric Phetteplace <phette23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42421 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org