[Bug 35430] New: Add endpoints for managing stock rotation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Bug ID: 35430 Summary: Add endpoints for managing stock rotation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com CC: tomascohen@gmail.com One endpoint for stockrotation already exists and was an early addition to the REST api's. We aught to complete the set and add endpoints for fetching and working with rota's. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897 [Bug 11897] Stock Rotation for Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159357&action=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159358&action=edit Bug 35430: Add unit tests for new stockrotation endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159359&action=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Test plan.. run the included unit tests and ensure they pass ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159357|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159360&action=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159358|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159361&action=edit Bug 35430: Add unit tests for new stockrotation endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159359|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159362&action=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add endpoints for managing |Add endpoints for managing |stock rotation |stock rotation rota's -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is especially useful as it is for EDI users using the LRP segment to auto-populate rotation plans on ordering. Vendors could use the Fetch API to populate the LRP options pick list in their portals. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159360|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 159418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159418&action=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159361|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 159419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159419&action=edit Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159362|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 159420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159420&action=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds API release notes| |endpoints for managing | |stock rotation rotas. --- Comment #12 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After apply the patch, run the new tests - these should pass: prove t/db_dependent/api/v1/stockrotation_rotas.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159418|0 |1 is obsolete| | Attachment #159419|0 |1 is obsolete| | Attachment #159420|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164134&action=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164135&action=edit Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 164136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164136&action=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Keywords| |rel_24_05_candidate --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, unit tests are failing, can you please have a look? Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t KO! # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 88. # Structures begin differing at: # $got->[2] = HASH(0x56028e088858) # $expected->[2] = Does not exist # Looks like you failed 1 test of 20. # Failed test 'list() tests' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 102. # Looks like you failed 1 test of 5. /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- 1538 commits since I last rebased the patch.. not all that surprising. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164134|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165538&action=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164135|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165539&action=edit Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164136|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165540&action=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165541&action=edit Bug 35430: (follow-up) Remove 'me' from query in tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have a failing test with this patch set applied, please check! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t KO! # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 88. # Structures begin differing at: # $got->[2] = HASH(0x55687bdd94d8) # $expected->[2] = Does not exist # Looks like you failed 1 test of 20. # Failed test 'list() tests' # at /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t line 102. # Looks like you failed 1 test of 5. /kohadevbox/koha/t/db_dependent/api/v1/stockrotation_rotas.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I don't understand this failure.. I have "me." In the query and it passes sometimes fails others.. I remove the "me." And it passes sometimes, fails others. Any thoughts Tomas, I'm stuck -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165538|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168202&action=edit Bug 35430: Move 'Stage' into StockRotation directory Cleaning up a little, I opt to move the 'Stage' controller under a new StockRotation parent directory. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165539|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168203&action=edit Bug 35430: Add unit tests for new stockrotation endpoints Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165540|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168204&action=edit Bug 35430: Add rota endpoints for stockrotation This patch adds the CRUD endpoints for stock rotation rota's. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It wasn't the 'me' at all.. it was the mocked object call. Anyway.. it works consistently now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35430 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org