[Bug 29664] New: Do not show voided payments in cash_register_stats.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Bug ID: 29664 Summary: Do not show voided payments in cash_register_stats.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: - take a payment of $1 - void that payment - go to reports, Cash Register (cash_register_stats.pl) and run a report for all payments taken today, see your voided payment We should not included voided credits, it throws off the totals. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Brittanie Maccarone <brittanie.maccarone@williamsoncounty-tn.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brittanie.maccarone@william | |soncounty-tn.gov --- Comment #1 from Brittanie Maccarone <brittanie.maccarone@williamsoncounty-tn.gov> --- We actively have a ticket for this issue, from Nov 2021. Duplicates being shown in our reports is affecting the information that is available to show the county that controls our funds. At the moment we are simply not using the function, and making notes elsewhere. But with multiple branches there is always the risk it gets used and shows our money as incorrect. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have just verified that this is still the beahviour on master. When limiting the search to payments, the voided payments show and the total given is wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148689&action=edit Bug 29664: Removing void payments from cash_register_stats Test Plan: 1. In a patron account create a manual fee of $1 2. Pay the amount of $1 3. Under Transactions, void the payment of $1. 4. Go to Reports > Cash Register > Run the report. A payment of $1 will show despite having voided the payment. 5. Apply patch and restart services. 6. Repeat step 4. Void payment should no longer show in the report. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Attachment #148689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148690&action=edit Bug 29664: Removing void payments from the cash register report Test Plan: 1. In a patron account create a manual fee of $1 2. Pay the amount of $1 3. Under Transactions, void the payment of $1. 4. Go to Reports > Cash Register > Run the report. A payment of $1 will show despite having voided the payment. 5. Apply patch and restart services. 6. Repeat step 4. Void payment should no longer show in the report. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148690|0 |1 is obsolete| | --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148691&action=edit Bug 29664: Removing void payments from the cash register report Test Plan: 1. In a patron account create a manual fee of $1 2. Pay the amount of $1 3. Under Transactions, void the payment of $1. 4. Go to Reports > Cash Register > Run the report. A payment of $1 will show despite having voided the payment. 5. Apply patch and restart services. 6. Repeat step 4. Void payment should no longer show in the report. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148691|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148692&action=edit Bug 29664: Removing void payments from the cash register report Test plan: 1. In a patron account create a manual fee of $1 2. Pay the amount of $1 3. Under Transactions, void the payment of $1. 4. Go to Reports > Cash Register > Run the report. A payment of $1 will show despite having voided the payment. 5. Apply patch and restart services. 6. Repeat step 4. Void payment should no longer show in the report. 7. Sign off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148692|0 |1 is obsolete| | --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148693&action=edit Bug 29664: Removing void payments from the cash register report Test plan: 1. In a patron account create a manual fee of $1 2. Pay the amount of $1 3. Under Transactions, void the payment of $1. 4. Go to Reports > Cash Register > Run the report. A payment of $1 will show despite having voided the payment. 5. Apply patch and restart services. 6. Repeat step 4. Void payment should no longer show in the report. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148693|0 |1 is obsolete| | --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 148694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148694&action=edit Bug 29664: Removing void payments from the cash register report Test plan: 1. In a patron account create a manual fee of $1 2. Pay the amount of $1 3. Under Transactions, void the payment of $1. 4. Go to Reports > Cash Register > Run the report. A payment of $1 will show despite having voided the payment. 5. Apply patch and restart services. 6. Repeat step 4. Void payment should no longer show in the report. 7. Sign off! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 149102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149102&action=edit Bug 29664: WIP Test Patch Test plan: 1. In a patron account create a manual fee of $5.00 - save and pay. 2. In the same patron account, create a manual fee of $1.00 - save and pay. 3. Under Transactions, void the payment of $5. Ensure that the “Account Type” shows that the $5 amount has been voided. 4. Go to Reports > Cash Register > Make sure that the “Transaction Type” is showing as “All payments to the library” > Run the report. 1. Check that both the $5.00 voided payment and the $1.00 regular payment are shown in the report. 5. Run the report again, but this time change the “Transaction Type” to “Credit has been voided”. Only the $5.00 voided payment should appear. 6. Apply the patch and restart services. 7. Repeat step 4. The report should only show the $1 payment. 8. Repeat step 5. No changes should occur - the $5.00 voided payment should still show. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150456&action=edit Bug 29664: Do not show voided payments in cash_register_stats.pl Test Plan: 1) Set up your cash register 2) Take a payment 3) Void that payment 4) Verify the voided fee shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the voided fee no longer shows for the "All payments to the library" and "Payment" transaction type filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|Laura.escamilla@bywatersolu |kyle@bywatersolutions.com |tions.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150456|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 150580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150580&action=edit Bug 29664: Do not show voided payments in cash_register_stats.pl Test Plan: 1) Set up your cash register 2) Take a payment 3) Void that payment 4) Verify the voided fee shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the voided fee no longer shows for the "All payments to the library" and "Payment" transaction type filters Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do not show voided payments |Do not show voided payments |in cash_register_stats.pl |in cash register statistics | |wizard CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is an entry in the pull downs "Credit has been voided" that makes me wonder if we should still show the voided payments somehow, but marked as such. Maybe give them their own entry in the list of types? I understand what you don't want to see them in payments. Would love to get another set of eyes on this one. Martin maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150580|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152887&action=edit Bug 29664: Do not show voided payments in cash_register_stats.pl Test Plan: 1) Set up your cash register 2) Take a payment 3) Void that payment 4) Verify the voided fee shows for the "All payments to the library" and "Payment" transaction type filters 5) Apply this patch 6) Restart all the things! 7) Verify the voided fee no longer shows for the "All payments to the library" and "Payment" transaction type filters Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152888&action=edit Bug 29664: (QA follow-up) Typo transacton Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #12)
There is an entry in the pull downs "Credit has been voided" that makes me wonder if we should still show the voided payments somehow, but marked as such. Maybe give them their own entry in the list of types?
I understand what you don't want to see them in payments.
Would love to get another set of eyes on this one. Martin maybe?
The filter is applied to PAYMENT and ACT. You could still see them with ALL or VOID? Seems that we overload VOID a bit btw: Koha/Account/Line.pm: debit_type_code => 'VOID', Koha/Account/Line.pm: status => 'VOID' Koha/Account/Line.pm: type => 'VOID', No reason to keep this here now. Last word to RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Andrii Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #20 from Andrii Nugged <nugged@gmail.com> --- Follow-up bug note: $whereTType .= q{ AND status != 'VOID' }; This makes MariaDB act unexpectedly: statuses with NULL are also skipped! When I added this to our piloting production: $whereTType .= q{ AND (status IS NULL OR status != 'VOID') }; it started to show those accountlines which has NULLs. Reasoning: https://mariadb.com/kb/en/null-values/ SELECT NULL != 'VOID', 'VOID' != 'VOID', 'TOTAL' != 'VOID'; +----------------+------------------+-------------------+ | NULL != 'VOID' | 'VOID' != 'VOID' | 'TOTAL' != 'VOID' | +----------------+------------------+-------------------+ | NULL | 0 | 1 | +----------------+------------------+-------------------+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34552 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34552 [Bug 34552] Statistics wizards : Cash register -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29664 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Andrii Nugged from comment #20)
Follow-up bug note:
$whereTType .= q{ AND status != 'VOID' };
This makes MariaDB act unexpectedly: statuses with NULL are also skipped! When I added this to our piloting production:
Make sure to file a new bug once an issue has been pushed. See bug 34552 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org