[Bug 37570] New: Add possibility to send request on other url defined by a new syspref SearchAlsoIn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Bug ID: 37570 Summary: Add possibility to send request on other url defined by a new syspref SearchAlsoIn Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: thibaud.guillot@biblibre.com QA Contact: testopia@bugs.koha-community.org Hello Like OPACSearchForTitleIn I would like to purpose you a new syspref "SearchAlsoIn" which adds the possibility of defining urls to launch the query on other sites. This can be added on both sides (personal pages and OPAC results pages). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170065&action=edit Bug 37570: Add SearchAlsoIn syspref SearchAlsoIn adds the possibility of defining urls to launch the query on the other sites. Dropdown menu appears on both sides (Staff and OPAC results pages) Test plan: 1) Apply this patch 2) Run updatedatabase 3) Perform a search on both sides (Staff and OPAC) 4) Click on "Search Also In" to see urls option to launch another query with your search Sponsored by: Institut français d’archéologie orientale (IFAO) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- Doesn't seem to apply on ktd: Applying: Bug 37570: Add SearchAlsoIn syspref Using index info to reconstruct a base tree... M catalogue/search.pl M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/searching.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql Auto-merging catalogue/search.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 37570: Add SearchAlsoIn syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #3 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- I like this idea. I came here to propose the same thing - a staff-side version of "OPACSearchForTitleIn." I hope to see this move forward! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> ---
if (my $search_also_in = C4::Context->preference('SearchAlsoIn')){ Ah looks like we never create var in condition.
$template->param('SearchAlsoIn' => $search_also_in); Feels strange that template var has the name of the preferences without being the preferences content.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #4)
if (my $search_also_in = C4::Context->preference('SearchAlsoIn')){ Ah looks like we never create var in condition.
Ahhhh forget about that, I was searching 'if (my' but tidy is 'if ( my' => We use that a lot ;D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170065|0 |1 is obsolete| | --- Comment #6 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 204052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204052&action=edit Bug 37570: Add SearchAlsoIn syspref SearchAlsoIn adds the possibility of defining urls to launch the query on the other sites. Dropdown menu appears on both sides (Staff and OPAC results pages) Test plan: 1) Apply this patch 2) Run updatedatabase 3) Perform a search on both sides (Staff and OPAC) 4) Click on "Search Also In" to see urls option to launch another query with your search Sponsored by: Institut français d’archéologie orientale (IFAO) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37570 --- Comment #7 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 204053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204053&action=edit Bug 37570: Tidy -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org