[Bug 6838] New: Filtering and pagination in subscriptions table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Bug #: 6838 Summary: Filtering and pagination in subscriptions table Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Serials AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: julian.maurice@biblibre.com QAContact: koha-bugs@lists.koha-community.org Will submit a patch that uses jQuery DataTables plugin to add pagination and filtering on subscriptions table (serials-home.pl) It will be a kind of 'how to use datatables' patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> 2011-09-02 14:51:28 UTC --- Created attachment 5295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5295 Patch This patch use dataTables instead of tablesorter for subscriptions table in serials-home.pl This table has now pagination, sorting, and can be filtered in two ways: by a global search field which search on all columns (except those marked with "bSearchable": false), and by a by column search field (which is in the table footer). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6836 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED CC| |nengard@gmail.com Patch Status|--- |Needs Signoff AssignedTo|colin.campbell@ptfs-europe. |julian.maurice@biblibre.com |com | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-09-07 15:57:20 UTC --- Created attachment 5342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5342 buggy This is cool but it has a few bugs in Firefox and Chrome on Mac. First the new subscription button isn't a button anymore. Next the search boxes below the table don't do anything. I type in them and it doesn't filter the results and there isn't a search button so I don't know how to search using those boxes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> 2011-09-16 07:16:19 UTC --- Did you pick up the last patch on bug 6836? This patch introduces a minor change that modify a javascript function name. I think this is why you experienced some bugs. I just tried to apply both patches on master, and it works for me (Firefox 6). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-09-27 16:28:09 UTC --- I missed the dependency note above. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> 2011-10-07 07:33:09 UTC --- My fault, I thought I had said it in 1st comment... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #6 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 11:04:53 UTC --- With the bug for 6836 applied, this works. I'm finding the whole table to be wider, and with a smaller font size, so we may need to adjust the CSS. I'd also like the ISSN column narrower, since ISSN is 9 char long and doesn't require any more than that. Also, condensing the last three columns to one ("Actions") with each action either on their own line, or separated by space, may help narrow the table. All in all, successful, at least on Mac + FF7. Other systems need testing, as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5342|0 |1 is obsolete| | --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 11:06:07 UTC --- Comment on attachment 5342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5342 buggy Obsoleting screenshot, since this issue goes away when 6836 is applied -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5295|0 |1 is obsolete| | --- Comment #8 from Frédéric Demians <frederic@tamil.fr> 2011-11-30 14:00:43 UTC --- Created attachment 6472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6472 Signed-off patch adding DataTable to serial-home.pl page It works as described in serials-home.pl page. And with Owen styling patch, it looks great. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6472|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> 2011-12-02 10:01:48 UTC --- Created attachment 6526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6526 New patch Rebased on what have been done in bug 6836 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2012-01-06 14:03:33 UTC --- Applies fine, but after it's applied I get : Software error: Template process failed: file error - datatables-strings.inc: not found at /home/nengard/kohaclone/C4/Templates.pm line 125. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. on the serials_home -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-12 10:37:08 UTC --- I think you need to retrieve the last version of datatables patches that add this missing file. See bug 6836. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2012-01-12 17:27:39 UTC --- I missed that depends on note - sorry about that. So I can't test this without 6836 Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6526|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:16:35 UTC --- Created attachment 7370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7370 Bug 6838: Add pagination and filtering on subscriptions table Use dataTables plugin Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jcamins@cpbibliography.com --- Comment #14 from Jared Camins-Esakov <jcamins@cpbibliography.com> 2012-01-28 15:17:48 UTC --- Nice work, Julian! This looks *GREAT*! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-01 21:30:04 UTC --- QA comment There is a small difference between readingrec (that is using Table sorter) and serials filter : the previous/next button have the text AND the button on this patch, there is only the button on readingrec. There is a 1 between pagination button on this patch, nothing on readingrec For consistency reason, please do on this patch as on readingrec. QA comment #2: I think the following code : if ( $previousbiblio eq $line->{biblionumber} ) { # Disabled for sorting and filtering on issn and title # to work on serials-home.pl #$line->{title} = ""; #$line->{issn} = ""; } else { $previousbiblio = $line->{biblionumber}; $odd = -$odd; } $line->{toggle} = 1 if $odd == 1; is useless. i've removed it, without seing any difference. Could you check ? if i'm right, the "my $previousbiblio='' and my $odd=1 " a few lines before are useless too -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7370|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> 2012-02-03 13:13:55 UTC --- Created attachment 7445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7445 Bug 6838: Add pagination and filtering on subscriptions table New patch with QA comments taken into account: - Use "four_button" pagination type like in readingrec.pl page - Remove useless $odd and $previousbiblio (both in .pl and .tt) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7445|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> 2012-02-07 19:29:54 UTC --- Created attachment 7492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7492 [SIGNED-OFF] Bug 6838: Add pagination and filtering on subscriptions table Use dataTables plugin Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-13 16:55:07 UTC --- QA comment: this time, no comment, passed QA, graphical consistency OK & dead code removed. template change only (except for the dead code remove) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Bug 6838 depends on bug 6836, which changed state. Bug 6836 Summary: jQuery plugin Datatables integration http://wiki.koha-community.org/wiki/DataTables_HowTo http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 What |Old Value |New Value ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6838 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> 2012-02-22 16:27:24 UTC --- Ok in master, marked as resolved -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org