[Bug 5281] New: "Check in" then "Renew" checkboxes checked in the same time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 Summary: "Check in" then "Renew" checkboxes checked in the same time Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: brice.sanchez@sys-tech.net QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Created attachment 2667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2667 "Check in" then "Renew" checkboxes checked in the same time In "Home › Circulation › Checkouts › briceSanc" . I'm unable to check "Renew" then "Check in" in the same time (i think its normal) but i'm able to check "Check in" then "Renew". I'm speaking about the checkboxes in the 'Checkout(s)' html table -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #1 from Brice Sanchez <brice.sanchez@sys-tech.net> 2010-10-06 14:42:48 UTC --- I have a patch ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 Brice Sanchez <brice.sanchez@sys-tech.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |brice.sanchez@sys-tech.net --- Comment #2 from Brice Sanchez <brice.sanchez@sys-tech.net> 2010-10-07 15:18:35 UTC --- Created attachment 2680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2680 Fix for bug 5281 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2010-10-07 16:49:15 UTC --- I found that this patch didn't help instances where the librarian has used the "override renewal limit" option. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #4 from Brice Sanchez <brice.sanchez@sys-tech.net> 2010-10-07 20:15:57 UTC --- (In reply to comment #3)
I found that this patch didn't help instances where the librarian has used the "override renewal limit" option.
I'm sorry but i don't understand what you mean. My patch is just a JS fix. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2010-10-11 12:13:27 UTC ---
I'm sorry but i don't understand what you mean. My patch is just a JS fix.
Yes, and the behavior I'm seeing is tied to JS. If the patron has checkouts which have been renewed too many times or they have checkouts which are on hold for someone else the renewal checkbox will be hidden. The staff user has the option of checking the "override" checkbox at the bottom of the table to override the renewal limit. When this is done the renew/check in checkboxes show the old buggy behavior. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #6 from Brice Sanchez <brice.sanchez@sys-tech.net> 2010-10-12 14:26:56 UTC --- (In reply to comment #5)
I'm sorry but i don't understand what you mean. My patch is just a JS fix.
Yes, and the behavior I'm seeing is tied to JS. If the patron has checkouts which have been renewed too many times or they have checkouts which are on hold for someone else the renewal checkbox will be hidden. The staff user has the option of checking the "override" checkbox at the bottom of the table to override the renewal limit. When this is done the renew/check in checkboxes show the old buggy behavior.
Ok, I see. This is the javascript that handles the clicks on the TD who is not working properly, it could be turned off !? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2010-10-15 13:45:22 UTC --- Created attachment 2690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2690 Proposed alterantive fix This fix corrects the behavior of the checkboxes whether the user clicks the checkbox itself or the <td> around it. Tested on a PC in Firefox 3.6, Chrome, Safari 5, and IE 8. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |cnighswonger@foundations.ed | |u --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-11-12 21:01:02 UTC --- Signed off and resubmitted. Applies to current HEAD. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2010-11-29 19:39:41 UTC --- Patch pushed please test and close -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 --- Comment #10 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2010-12-10 10:23:29 UTC --- This bug is mentioned in: Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time http://lists.koha-community.org/pipermail/koha-patches/2010-November/012946.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5281 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |wizzyrea@gmail.com Resolution| |FIXED --- Comment #11 from Liz Rea <wizzyrea@gmail.com> 2010-12-23 19:33:16 UTC --- I confirm that the buggy behavior has been eradicated both with and without the override checkbox checked. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org