[Bug 36165] New: Update "Tools" landing page to be more consistent with 'Cataloging' and 'Circulation' landing pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Bug ID: 36165 Summary: Update "Tools" landing page to be more consistent with 'Cataloging' and 'Circulation' landing pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Blocks: 36164 We should take inspiration from existing landing pages, Cataloging, Circulation, Reports, and Administration all come to mind. It would be great to have all of these manifest in a more consistent form. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 [Bug 36164] Bring more consistency to our module landing pages -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #1 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I would love to see both the tools and the administration landing page updated to have a similar look to the cataloging and circulation pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|NEW |CONFIRMED --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Sounds interesting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, Hackfest -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |olivia.reynolds@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #3 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 200755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200755&action=edit Bug 36165: Use standard landing page components for Tools This patch introduces a new set of TT blocks for landing pages, based on Pedro's PoC in Bug 36164. These definitions were sourced from the Cataloging landing page, with the addition of a `tooltip` option. These new building blocks are used to redesign the Tools landing page. The additional column is dedicated to plugins - the idea being that plugins were explicitly installed by users so are likely to be important to their workflows and should be near the top. The existing help text has been converted into tooltip prompts for each button. I've tried to match icons to similar buttons on other landing pages, though in some cases I couldn't find any and tried to pick something reasonable. Test plan: 1. Apply patch. 2. Navigate to Tools (under More in the admin header). 3. Verify the page loads successfully. 4. Verify every button can be reached and read. 5. Verify every button has appropriate tooltip text. 6. Verify that the target URL of each button is correct. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #4 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 200758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200758&action=edit Screenshot of tools landing page redesign For ease of reference, I've also attached a screenshot of the new design. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Needs Signoff |Signed Off Comma delimited| |Open Fifth list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 200808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200808&action=edit Bug 36165: Use standard landing page components for Tools This patch introduces a new set of TT blocks for landing pages, based on Pedro's PoC in Bug 36164. These definitions were sourced from the Cataloging landing page, with the addition of a `tooltip` option. These new building blocks are used to redesign the Tools landing page. The additional column is dedicated to plugins - the idea being that plugins were explicitly installed by users so are likely to be important to their workflows and should be near the top. The existing help text has been converted into tooltip prompts for each button. I've tried to match icons to similar buttons on other landing pages, though in some cases I couldn't find any and tried to pick something reasonable. Test plan: 1. Apply patch. 2. Navigate to Tools (under More in the admin header). 3. Verify the page loads successfully. 4. Verify every button can be reached and read. 5. Verify every button has appropriate tooltip text. 6. Verify that the target URL of each button is correct. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Nice work! I like the tool tips. I think we need to put some work into grouping the tools, as the list are very long. But that is outside the scope of this bug 8-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I like the new components, they allow us to share more code between these pages. We should probably follow-up with a couple of bugs to update the existing landing pages to use them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |oleonard@myacpl.org |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42894 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42894 [Bug 42894] Port "Circulation" and "Cataloging" landing pages to a standard set of components -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Needs Signoff Comma delimited|Open Fifth |Athens County Public list of Sponsors| |Libraries, Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202731&action=edit Bug 36165: (follow-up) Reorganize items and columns This patch attempt to make the new tools page layout work better in three columns by splitting "Patrons and Circulation" into "Patrons" and "Circulation," and by moving around the sections for Cash management and Tool plugins to help make the columns more equal (when all tools are displayed). I have also added a "Catalog" heading. To test, apply the patch and log into Koha as a superlibrarian. - Go to Tools. - Confirm that the columns and elements on the page look well-organized. - Confirm that the division of tools into Circulation, Patrons, and Catalog makes sense. - Install a plugin in the "Tools" class (I found PDFtoCover) and check the display of that link on the tools home page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200808|0 |1 is obsolete| | Attachment #202731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 202752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202752&action=edit Bug 36165: Use standard landing page components for Tools This patch introduces a new set of TT blocks for landing pages, based on Pedro's PoC in Bug 36164. These definitions were sourced from the Cataloging landing page, with the addition of a `tooltip` option. These new building blocks are used to redesign the Tools landing page. The additional column is dedicated to plugins - the idea being that plugins were explicitly installed by users so are likely to be important to their workflows and should be near the top. The existing help text has been converted into tooltip prompts for each button. I've tried to match icons to similar buttons on other landing pages, though in some cases I couldn't find any and tried to pick something reasonable. Test plan: 1. Apply patch. 2. Navigate to Tools (under More in the admin header). 3. Verify the page loads successfully. 4. Verify every button can be reached and read. 5. Verify every button has appropriate tooltip text. 6. Verify that the target URL of each button is correct. Sponsored-by: Open Fifth Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 202753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202753&action=edit Bug 36165: (follow-up) Reorganize items and columns This patch attempt to make the new tools page layout work better in three columns by splitting "Patrons and Circulation" into "Patrons" and "Circulation," and by moving around the sections for Cash management and Tool plugins to help make the columns more equal (when all tools are displayed). I have also added a "Catalog" heading. To test, apply the patch and log into Koha as a superlibrarian. - Go to Tools. - Confirm that the columns and elements on the page look well-organized. - Confirm that the division of tools into Circulation, Patrons, and Catalog makes sense. - Install a plugin in the "Tools" class (I found PDFtoCover) and check the display of that link on the tools home page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Owen - really like the groupings you have come up with! One thing I did notice, but I'm assuming it is something with the plugin, is that I got a 500 error when attempting to access it from the tools page, but not from the plugins page: - URL from the tools page - Error 500: /cgi-bin/koha/plugins/run.pl?class=Koha%253A%253APlugin%253A%253APDFtoCover&method=tool - URL from the actual plugin page Administration > Plugins > Manage plugins > Actions > Run tool: /cgi-bin/koha/plugins/run.pl?class=Koha%3A%3APlugin%3A%3APDFtoCover&method=tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 202804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202804&action=edit Bug 36165: (follow-up) Avoid double-encoding URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #13 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 202848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202848&action=edit Bug 36165: (follow-up) Avoid double-encoding URL Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #14 from Juliet Heltibridle <jheltibridle@rcplib.org> --- Looks good and the tools plugin links correctly now. I also tested using a user with partial Tools permissions, and everything looked correct. Screen reader also read the tooltips correctly. They're a nice addition! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Rebased on top of Bug 10190. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Olivia Reynolds <olivia.reynolds@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202752|0 |1 is obsolete| | Attachment #202753|0 |1 is obsolete| | Attachment #202848|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #16 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206231&action=edit Bug 36165: Use standard landing page components for Tools This patch introduces a new set of TT blocks for landing pages, based on Pedro's PoC in Bug 36164. These definitions were sourced from the Cataloging landing page, with the addition of a `tooltip` option. These new building blocks are used to redesign the Tools landing page. The additional column is dedicated to plugins - the idea being that plugins were explicitly installed by users so are likely to be important to their workflows and should be near the top. The existing help text has been converted into tooltip prompts for each button. I've tried to match icons to similar buttons on other landing pages, though in some cases I couldn't find any and tried to pick something reasonable. Test plan: 1. Apply patch. 2. Navigate to Tools (under More in the admin header). 3. Verify the page loads successfully. 4. Verify every button can be reached and read. 5. Verify every button has appropriate tooltip text. 6. Verify that the target URL of each button is correct. Sponsored-by: Open Fifth -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #17 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206232&action=edit Bug 36165: (follow-up) Reorganize items and columns This patch attempt to make the new tools page layout work better in three columns by splitting "Patrons and Circulation" into "Patrons" and "Circulation," and by moving around the sections for Cash management and Tool plugins to help make the columns more equal (when all tools are displayed). I have also added a "Catalog" heading. To test, apply the patch and log into Koha as a superlibrarian. - Go to Tools. - Confirm that the columns and elements on the page look well-organized. - Confirm that the division of tools into Circulation, Patrons, and Catalog makes sense. - Install a plugin in the "Tools" class (I found PDFtoCover) and check the display of that link on the tools home page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #18 from Olivia Reynolds <olivia.reynolds@openfifth.co.uk> --- Created attachment 206233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206233&action=edit Bug 36165: (follow-up) Avoid double-encoding URL Signed-off-by: Juliet Heltibridle <jheltibridle@rcplib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from David Nind <david@davidnind.com> --- The patch still applies, however: 1. "Notices and slips" is under both the Circulation and Patrons sections. 2. After clicking on individual tools, the sidebar groupings are the same as before the patch. I think these need updating, or a separate bug to update these. I had a go at grouping the additional tools section: Content tools - CSV profiles - HTML customizations - News - Pages - Record display customizations (or maybe under Catalog?) - Quote editor - Uploads - Access files System tools - Calendar - Log viewer - Task scheduler -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |26.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Initiative type|--- |Feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208115&action=edit Bug 36165: (follow-up) Divide additional tools into "content" and "system" Also changing section heading to <h2> instead of <h3> to maintain correct heading sequence. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36165 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #21 from David Nind <david@davidnind.com> --- Thanks Owen for fixing the duplicated notices and slips entry, and adding the content and system categories. Good spotting about the heading levels! However, I've Failed QA as: 1. CSV profiles link (note the ? after the URL): - Before patches: /cgi-bin/koha/tools/csv-profiles.pl - After patches: /cgi-bin/koha/tools/csv-profiles.pl? 2. With the PDFtoCover tool plugin enabled, this extra info is added to all the tools listed after the tools plugin section: ?class=Koha%3A%3APlugin%3A%3APDFtoCover&method=tool - Example, the uploads tool: /cgi-bin/koha/tools/upload.pl?class=Koha%3A%3APlugin%3A%3APDFtoCover&method=tool - It also causes an error when submitting changes such as news, pages and HTML customizations: "An error occurred when adding this content. Check the logs for details." 3. Both of these were there before the latest follow-up patch, but I didn't notice these last time I tested. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org