[Bug 12311] New: Batch modification of checked out and lost items checks them in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Bug ID: 12311 Summary: Batch modification of checked out and lost items checks them in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If you use the batch modification tool to change details of an item which is checked out and lost the item is checked in. To reproduce: 1. Identify items which are checked out and lost. 2. Submit these items for batch modification. 3. Choose any field to modify: collection code, item type, price, etc. 4. Complete the modifications. 5. Confirm that these items are no longer checked out. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5533 CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |nengard@gmail.com Status|NEW |In Discussion --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It seems that this behavior exists for a while. There was a discussion on bug 5533 and I am not sure how we should fix this bug. bug 5533 comment 2: "Another update - if you mark items lost using the batch edit tool the lost items remain on the patron's record as checked out instead of being removed." I am sure it's easy to fix, but I would like to know the different use cases to take into account. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5533 [Bug 5533] marking item lost diff in two places -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The code is: 200 if ( my $item = ModItemFromMarc( $localmarcitem, $itemdata->{biblionumber}, $itemnumber ) ) { 201 LostItem($itemnumber, 'MARK RETURNED') if $item->{itemlost}; 202 } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com | |, katrin.fischer@bsz-bw.de --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I need help on this one to provide a fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ping? Is this really critical? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think yes. If it's true it unexpectedly checks items in, then that's really bad. I think the problem might be that Koha ususally wants to return an item if it's set to lost... and only the longoverdue script manages to avoid this? What about: only trigger the check in, if the lost status is changed in the batch edit? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42554&action=edit Bug 12311: Do not return a lost item if modified in a batch If a item is lost and issued, and you modify it in a batch, the item will be marked as returned. It should only be returned if the item is marked as lost. Test plan: 1/ Check an item out and mark it as lost 2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for instance) 3/ The item should still be issued to the patron 4/ Edit it in a batch and edit the lost value, marked it as not lost 5/ The item should still be issued to the patron 6/ Edit it in a batch and edit the lost value, marked it as lost 7/ The item should have been returned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42554|0 |1 is obsolete| | --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 42796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42796&action=edit [SIGNED-OFF]Bug 12311: Do not return a lost item if modified in a batch If a item is lost and issued, and you modify it in a batch, the item will be marked as returned. It should only be returned if the item is marked as lost. Test plan: 1/ Check an item out and mark it as lost 2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for instance) 3/ The item should still be issued to the patron 4/ Edit it in a batch and edit the lost value, marked it as not lost 5/ The item should still be issued to the patron 6/ Edit it in a batch and edit the lost value, marked it as lost 7/ The item should have been returned. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Just one comment, lost status can be changed only if you change default framework to another framework then edit the item. If you change it in Item menu at left side of screen this will remove the item from patron’s checkouts and patron charged for lost item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42796|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42961&action=edit [PASSED QA] Bug 12311: Do not return a lost item if modified in a batch If a item is lost and issued, and you modify it in a batch, the item will be marked as returned. It should only be returned if the item is marked as lost. Test plan: 1/ Check an item out and mark it as lost 2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for instance) 3/ The item should still be issued to the patron 4/ Edit it in a batch and edit the lost value, marked it as not lost 5/ The item should still be issued to the patron 6/ Edit it in a batch and edit the lost value, marked it as lost 7/ The item should have been returned. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Just one comment, lost status can be changed only if you change default framework to another framework then edit the item. If you change it in Item menu at left side of screen this will remove the item from patron’s checkouts and patron charged for lost item. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> For testing purposes the lost item field can be set to visible in the framework used. That will allow changing it without returning it at the same time. The other option is using the longoverdues.pl script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, is in 3.18.12. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org