[Bug 23823] New: Allow system preferences to be bookmarked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Bug ID: 23823 Summary: Allow system preferences to be bookmarked Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: helix84@centrum.sk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 94271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94271&action=edit screenshot Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #1 from Ivan Masár <helix84@centrum.sk> --- Created attachment 94272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94272&action=edit Bug 23823: Allow system preferences to be bookmarked Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |helix84@centrum.sk |ity.org | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't forget to change the status to 'Needs Signoff' once you have attached your patches for testing. You should also change the Assignee to yourself, once you have decided to work on something. Thx for the contribution! :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94272|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94361&action=edit Bug 23823: Allow system preferences to be bookmarked Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94362&action=edit Bug 23823: (follow-up) Get rid of some tabs in favor of spaces In the paragraph touched by this patch, there were some whitespace issues. This patch does some tab to space replacement and reindentation to make the code more readable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Ivan, Welcome to the team, it's great to have another new contributor. I'm afraid the QA scripts throw up a minor error: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt FAIL filters wrong_html_filter at line 59 ( <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=[% NAME.name | html %]">) It's should be simple enough to fix, you just need to replace the `| html` with `| uri` as the template variable is being used inside a url string here. A quick followup with that change as it's own little patch would be perfect and then I can pass qa on this set. Many thanks, Martin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Secondary thought, I wonder if it might be 'nicer' to link to the preference in context (rather than individually displayed as a search result) using anchors instead? Something along the lines of giving the `code` block an id of the preference code and then constructing the link following something like `/cgi-bin/koha/admin/preferences.pl?tab=accounting/#pref_code`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #6)
Secondary thought, I wonder if it might be 'nicer' to link to the preference in context (rather than individually displayed as a search result) using anchors instead?
Something along the lines of giving the `code` block an id of the preference code and then constructing the link following something like `/cgi-bin/koha/admin/preferences.pl?tab=accounting/#pref_code`.
Sorry for missing the filter - missed it when I fixed some tabs over spaces. I feel this is a pragmatic solution that we could still extend later on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tbh, I also like the 'without context' approach here. you could modify the bookmark to make a more general search if you wanted some more to show. But it would make link in documentation etc. very clear and easy to follow without having to locate the right pref again on a page, where it might show at the top, or the middle, depending on length of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Ivan Masár <helix84@centrum.sk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Ivan Masár <helix84@centrum.sk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94362|0 |1 is obsolete| | --- Comment #9 from Ivan Masár <helix84@centrum.sk> --- Created attachment 94366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94366&action=edit Bug 23823: (follow-up) Get rid of some tabs in favor of spaces In the paragraph touched by this patch, there were some whitespace issues. This patch does some tab to space replacement and reindentation to make the code more readable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Ivan Masár <helix84@centrum.sk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #10 from Ivan Masár <helix84@centrum.sk> --- Thank you for review. When I was originally looking for a way to bookmark sysprefs, I thought I will just bookmark the anchor like Martin suggested. There were no anchors, so I looked some more and found the search/filter, which worked for me. Now that I've been using it for a while I like it more for the same reason Katrin mentioned - if I know exactly what I'm looking for, I don't need to potentially look for it wherever it may land on screen. That said, I see two ways to improve the current situation: 1) Since this is substring search, not exact search, bookmarking GoogleOpenIDConnect will also show GoogleOpenIDConnectAutoRegister and a few others. My intent was to link to one exact syspref. Is there a parameter to specify exact search? 2) If context is what's desired, we may add a bookmark icon for section anchors (e.g. anchor "Google OpenID Connect" on the Administration tab). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #11 from Ivan Masár <helix84@centrum.sk> --- Also, I just noticed there's systempreferences.pl (vs preferences.pl). Is this newer, older or something else entirely? (asking just in case I'm making changes to code to be deprecated) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One of them is used for local prefs that are not reflected in the YAML files and for that not searchable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- See tab "Local use" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23388 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- It's just come to my attention that bug 23388 is attempting to do something similar to this already... just trying to work out how they sit in context. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Ivan Masár <helix84@centrum.sk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #15 from Ivan Masár <helix84@centrum.sk> --- Created attachment 94367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94367&action=edit Bug 23823: (follow-up) minor visual fix Do not allow a line break between the bookmark icon and syspref name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #16 from Ivan Masár <helix84@centrum.sk> --- @Martin: I see that bug 23388 provides the previously mentioned alternate solution via anchor links. Nice to see that I'm not the only one who had the same need (I haven't seen the other bug before). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- I've posted a work-in-progress patch to Bug 23388. If anyone is interested in testing I'd love to get some feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94367|0 |1 is obsolete| | --- Comment #18 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 111625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111625&action=edit Bug 23823: (follow-up) minor visual fix Do not allow a line break between the bookmark icon and syspref name. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94361|0 |1 is obsolete| | --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 111626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111626&action=edit Bug 23823: Allow system preferences to be bookmarked Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94366|0 |1 is obsolete| | --- Comment #20 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 111627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111627&action=edit Bug 23823: (follow-up) Get rid of some tabs in favor of spaces In the paragraph touched by this patch, there were some whitespace issues. This patch does some tab to space replacement and reindentation to make the code more readable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Ivan Masár <helix84@centrum.sk> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111625|0 |1 is obsolete| | --- Comment #21 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 111628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111628&action=edit Bug 23823: (follow-up) minor visual fix Do not allow a line break between the bookmark icon and syspref name. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #22 from Séverine Queune <severine.queune@bulac.fr> --- Sorry for the first bad sign off, forgot to check the number of attachments... Hope it won't be a problem for QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |oleonard@myacpl.org --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Owen, can you take a look here and let me know if you approve? It works for me, but I think maybe it has the same issues you didn't like on 23388 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Nick Clemens from comment #23)
It works for me, but I think maybe it has the same issues you didn't like on 23388
No, the issues I had with how Bug 23388 was working aren't relevant to this patch. I think this one works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111626|0 |1 is obsolete| | Attachment #111627|0 |1 is obsolete| | Attachment #111628|0 |1 is obsolete| | --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111864&action=edit Bug 23823: Allow system preferences to be bookmarked Test plan: 1) Log in to Staff UI with superlibrarian permissions 2) Go to System Preferences /cgi-bin/koha/admin/preferences.pl 3) Next to each preference, there should now be a bookmark icon 4) The bookmark icon links to a search for the exact preference name 5) The link can be bookmarked for quick reference to the specific preference Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111865&action=edit Bug 23823: (follow-up) Get rid of some tabs in favor of spaces In the paragraph touched by this patch, there were some whitespace issues. This patch does some tab to space replacement and reindentation to make the code more readable. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Ivan Masár <helix84@centrum.sk> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111866&action=edit Bug 23823: (follow-up) minor visual fix Do not allow a line break between the bookmark icon and syspref name. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111867&action=edit Bug 23823: (QA follow-up) Fix filter in link Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 23388 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #30 from David Cook <dcook@prosentient.com.au> --- This looks very useful. Great to see a Koha patch from you, Ivan! For those that don't know, Ivan (helix84) has been contributing to DSpace for quite a few years now. Hopefully we'll see more patches :D. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Congratulations for your first patch pushed, Ivan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23823 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org