[Bug 13795] New: Delete unused columns from statistics table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Bug ID: 13795 Summary: Delete unused columns from statistics table. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nengard@gmail.com Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org I ran the following on a system that has been using Koha for 3 years and it appears that none of these fields are ever used: mysql> select distinct proccode from statistics; +----------+ | proccode | +----------+ | NULL | +----------+ 1 row in set (0.00 sec) mysql> select distinct other from statistics; +-------+ | other | +-------+ | | +-------+ 1 row in set (18.30 sec) mysql> select distinct usercode from statistics; +----------+ | usercode | +----------+ | NULL | +----------+ 1 row in set (0.03 sec) mysql> select distinct associatedborrower from statistics; +--------------------+ | associatedborrower | +--------------------+ | NULL | +--------------------+ 1 row in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 36578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36578&action=edit Bug 13795: Delete unused columns from stats table The following 4 fields are never used in the statistics table: associatedborrower other proccode usercode This patch removes them. To test: * check the database and make sure columns are gone -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org Status|Needs Signoff |Failed QA --- Comment #2 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I have something in proccode, but nothing in others: mysql> select distinct proccode from statistics; +----------+ | proccode | +----------+ | NULL | | | | 1 | | 2 | | 3 | | 6 | +----------+ 6 rows in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- All this columns are used by module Koha/Schema/Result/Statistic.pm Inside the file it read # Created by DBIx::Class::Schema::Loader # DO NOT MODIFY THE FIRST PART OF THIS FILE and # Created by DBIx::Class::Schema::Loader v0.07025 @ 2013-10-14 20:56:21 # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:THELVmdFFi1RCI4DfqwGIw -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Failed QA |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hector, those files are generated from the database - so all the columns will appear there, but it doesn't indicate that they are used. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Patch does not apply. Besides, there are other places that reference some of this values e.g. proccode koha-tmpl/intranet-tmpl/prog/en/columns.def:<field name="statistics.proccode">Type of procedure</field> t/db_dependent/Stats.t:is ($params-> {accountno}, $line->{proccode}, "UpdateStats save accountno param in proccode field of statistics table"); -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org