[Bug 24058] New: acquisition table displayed even if no order exist (bib detail)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Bug ID: 24058 Summary: acquisition table displayed even if no order exist (bib detail) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 20366 The acquisition table is displayed on the bibliographic detail page, even if the record has not been ordered. It is caused by commit 43326754b110c62fbb2909eea1595656833f8c02 Bug 20366: Add subscription info to the acq tab on the biblio detail page The "orders" variable sent to the template switched from an arrayref to a Koha::Acquisition::Orders object. The condition [% IF orders %] in the template is no longer correct (always true) and must be replaced with [% IF orders.count %] Wrong display: https://snipboard.io/wXOHLJ.jpg Expected display: https://snipboard.io/E8GP6K.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95523&action=edit Bug 24058: acquisition table displayed even if no order exist (bib detail) This patch corrects the template check for existence of acquisitions data on the bibliographic detail page. Now it will correctly hide the DataTable when there is no data. To test, apply the patch and enable the AcquisitionDetails system preference. - View the bibliographic detail page for a title which has no associated Acquisitions data. Under the "Acquisitions details" tab you should see only a message, "There is no order for this biblio." - View the detail page for a title which has associated Acquisitions data. The "Acquisitions details" tab should show the correct information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95523|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95528&action=edit Bug 24058: acquisition table displayed even if no order exist (bib detail) This patch corrects the template check for existence of acquisitions data on the bibliographic detail page. Now it will correctly hide the DataTable when there is no data. To test, apply the patch and enable the AcquisitionDetails system preference. - View the bibliographic detail page for a title which has no associated Acquisitions data. Under the "Acquisitions details" tab you should see only a message, "There is no order for this biblio." - View the detail page for a title which has associated Acquisitions data. The "Acquisitions details" tab should show the correct information. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95528|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95650&action=edit Bug 24058: acquisition table displayed even if no order exist (bib detail) This patch corrects the template check for existence of acquisitions data on the bibliographic detail page. Now it will correctly hide the DataTable when there is no data. To test, apply the patch and enable the AcquisitionDetails system preference. - View the bibliographic detail page for a title which has no associated Acquisitions data. Under the "Acquisitions details" tab you should see only a message, "There is no order for this biblio." - View the detail page for a title which has associated Acquisitions data. The "Acquisitions details" tab should show the correct information. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|acquisition table displayed |Acquisition table displayed |even if no order exist (bib |even if no order exist (bib |detail) |detail) CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org