[Bug 16538] New: Improve the style of progress bars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Bug ID: 16538 Summary: Improve the style of progress bars Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 51581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51581&action=edit Screenshot of a progress bar before the patch I would like to add some style to progress bars on various pages to make them look a little nicer. See attached for before and after screenshots. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51582&action=edit Screenshot of a progress bar after the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529 [Bug 16529] Clean up and improve upload template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51583&action=edit Bug 16538 - Improve the style of progress bars This patch updates the style of progress bars to make them a little nicer. Progress bars in the staff client are not built in a consisten way. Some have been updated to use the <progress> element and some have not. This patch improves some styling common to both kinds. Other changes: - Redundant in-page CSS has been removed from many pages. - An invalid "min" attribute has been removed from several instances of <progress>. - Corrected capitalization. - Fixed incorrectly quoted attributes. - Added missing form "action" attributes. To test, clear your browser cache if necessary. Apply the patch and test uploads on the following pages: - Circulation -> Offline circulation file upload - Tools -> Batch item modification - Tools -> Batch record modification - Tools -> Stage MARC records for import - Tools -> Manage staged MARC records - Tools -> Upload local cover image - Tools -> Upload In all cases, progress bars should look improved and work correctly. Test Tools -> Batch item deletion. Unused background job handling markup has been removed. Deletion processing should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Owen Applying: Bug 16538 - Improve the style of progress bars Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt Auto-merging koha-tmpl/intranet-tmpl/prog/css/staff-global.css Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Conflicts caused by bug 16468 (added missing quote on ISO-8859-1 value as well as reformatted select) and bug 16602 (removed onclick and added id of same value as name attribute). I'll let Owen fix this as both those other bugs are Owen's as well, unless he comments otherwise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51583|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53389&action=edit Bug 16538 - Improve the style of progress bars This patch updates the style of progress bars to make them a little nicer. Progress bars in the staff client are not built in a consisten way. Some have been updated to use the <progress> element and some have not. This patch improves some styling common to both kinds. Other changes: - Redundant in-page CSS has been removed from many pages. - An invalid "min" attribute has been removed from several instances of <progress>. - Corrected capitalization. - Fixed incorrectly quoted attributes. - Added missing form "action" attributes. To test, clear your browser cache if necessary. Apply the patch and test uploads on the following pages: - Circulation -> Offline circulation file upload - Tools -> Batch item modification - Tools -> Batch record modification - Tools -> Stage MARC records for import - Tools -> Manage staged MARC records - Tools -> Upload local cover image - Tools -> Upload In all cases, progress bars should look improved and work correctly. Test Tools -> Batch item deletion. Unused background job handling markup has been removed. Deletion processing should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53389|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 53401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53401&action=edit [SIGNED-OFF]Bug 16538: Improve the style of progress bars This patch updates the style of progress bars to make them a little nicer. Progress bars in the staff client are not built in a consisten way. Some have been updated to use the <progress> element and some have not. This patch improves some styling common to both kinds. Other changes: - Redundant in-page CSS has been removed from many pages. - An invalid "min" attribute has been removed from several instances of <progress>. - Corrected capitalization. - Fixed incorrectly quoted attributes. - Added missing form "action" attributes. To test, clear your browser cache if necessary. Apply the patch and test uploads on the following pages: - Circulation -> Offline circulation file upload - Tools -> Batch item modification - Tools -> Batch record modification - Tools -> Stage MARC records for import - Tools -> Manage staged MARC records - Tools -> Upload local cover image - Tools -> Upload In all cases, progress bars should look improved and work correctly. Test Tools -> Batch item deletion. Unused background job handling markup has been removed. Deletion processing should work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Just a comment: Would be great if Koha uses just one style of progress bar, right now I could see three styles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53401|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53436&action=edit Bug 16538: Improve the style of progress bars This patch updates the style of progress bars to make them a little nicer. Progress bars in the staff client are not built in a consisten way. Some have been updated to use the <progress> element and some have not. This patch improves some styling common to both kinds. Other changes: - Redundant in-page CSS has been removed from many pages. - An invalid "min" attribute has been removed from several instances of <progress>. - Corrected capitalization. - Fixed incorrectly quoted attributes. - Added missing form "action" attributes. To test, clear your browser cache if necessary. Apply the patch and test uploads on the following pages: - Circulation -> Offline circulation file upload - Tools -> Batch item modification - Tools -> Batch record modification - Tools -> Stage MARC records for import - Tools -> Manage staged MARC records - Tools -> Upload local cover image - Tools -> Upload In all cases, progress bars should look improved and work correctly. Test Tools -> Batch item deletion. Unused background job handling markup has been removed. Deletion processing should work correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19674 [Bug 19674] Broken indicators of changed fields in manage staged MARC records template -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org