[Bug 40172] New: Remove jQuery from js/fetch/http-client.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Bug ID: 40172 Summary: Remove jQuery from js/fetch/http-client.js Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org We do not really need jQuery, it can be replace with vanilla JavaScript. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 183353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183353&action=edit Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40173 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40173 [Bug 40173] Reuse http-client from Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |unspecified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #0)
We do not really need jQuery, it can be replace with vanilla JavaScript.
This makes me very happy :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I just tested with the syspref endpoint, but that does test all the changes. Test plan: 0. Apply the patch 1. Log into staff interface 2. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=opacuserjs&ok=Search 3. Add a JS comment 4. Note that it succeeds 5. In a separate tab, log out of the staff interface 6. Try to update the JS comment 7. Note that the message "Error: Forbidden" appears at the top of the page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183353|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 183361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183361&action=edit Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183361|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 183871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183871&action=edit Bug 40172: Replace jQuery with vanilla JS in js/fetch/http-client.js So that we can reuse it from somewhere else. The current need is to be able to reuse it from Cypress tests. Test plan: Try to hit several places where APIClient is used: * Syspref edition * Translation of item type description (be aware of bug 40161) * Delete of cover images * checkin, renew from the checkout list * etc. Note that this does not affect Vue components. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k CC| |pedro.amorim@openfifth.co.u | |k Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40172 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org