https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15108 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17807 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108 [Bug 15108] OAI-PMH provider improvements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make possible to have |Make possible to have |custom configuration for |custom XSL template for |marcxml and marc21 metadata |marcxml and marc21 metadata |prefixes in OAI server |prefixes in OAI server -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69531&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.stastny@teamlibrary. | |cz --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- *** Bug 20129 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72554&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76332&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #9 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Martin 357astný <martin.stastny@teamlibrary.cz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 77470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77470&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t Signed-off-by: Martin 357astný <martin.stastny@teamlibrary.cz> Signed-off-by: Martin 357astný <martin.stastny@teamlibrary.cz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- t/db_dependent/OAI/oaiconf.yaml references a file that exists only if koha is installed using the Debian packages. If this file is not present, tests fail. Also, tests fail if marcflavour == 'UNIMARC'. Please fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77470|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111006&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t Signed-off-by: Martin Šťastný <martin.stastny@teamlibrary.cz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 111009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111009&action=edit Bug 19353: Fix tests on UNIMARC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #12)

@Josef, can I ask for some more instructions on configuring the OAI server with specific files? A sample file would also be great for testing.

Katrin, this is configuration we are using on production: https://gitlab.com/open-source-knihovna/KohaCZ/-/blob/master/etc/oaiconf.yam... https://gitlab.com/open-source-knihovna/KohaCZ/-/tree/master/etc/xslt I do recomend to try the marc21 metadata format with ModifyMarc.xslt https://gitlab.com/open-source-knihovna/KohaCZ/-/blob/master/etc/xslt/Modify... It is relatively simple, other templates we are using are a bit more complex.... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111006|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111525&action=edit Bug 19353: Ability to use xsl template on marc21 and marcxml metadataprefixes in OAI provider Test plan: 0) apply the patchset 1) setup oai server with oaiconf file defining xsl_file for metadata format marcxml or marc21 2) play with your oai and confirm that records are transformed as expected 3) prove t/db_dependent/OAI/Server.t Signed-off-by: Martin Šťastný <martin.stastny@teamlibrary.cz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111009|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111527&action=edit Bug 19353: Fix tests on UNIMARC Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #24)

It was a bit of struggle to get the OAI to cooperate (thx to Joonas helping me out!), but I finally managed a proper test and this appears to be working just fine :)

Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19353 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.