[Bug 5436] New: Extended patron attributes display improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Summary: Extended patron attributes display improvements Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Enhancements_to_th e_display_of_extended_patron_attributes_in_circ OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Extended patron attributes are a great tool: it provides nice flexibility in the information one wants to manage in the patron's record. But as of version 3.2 we don't have any way to manage how this information will be displayed once entered. For some extended attributes, it might be useful to have them display in circ/circulation.pl, in the Check Out tab, which is arguably the most important tab in this page, rather than at the end of the Details page. This RFC proposes: when looking up a patron from members-home.pl and having one and only one result, one should go straight to the member.pl, not have a table with 1 result only; on circ/returns.pl page when I click on a patron's name (link), I should not go to koha/members/moremember.pl?borrowernumber=XXX but to koha/circ/circulation.pl?borrowernumber=XXX to add a field to admin/patron-att-types.pl?op=edit -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Blocks| |5575 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |julian.maurice@biblibre.com --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-21 10:03:35 UTC --- Created attachment 3378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3378 Patch from BibLibre -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-03-22 20:48:42 UTC --- I was testing this and I clicked on the patron 'check out' tab and I saw a message that my patron has been renewed ... I didn't click renew - just 'check out' so I think there is a tiny bug in this patch. I'm back to testing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-03-22 20:50:28 UTC --- That's the only thing I found wrong with this patch - but I just want to check to see what you mean by attributes - there are patron attributes in Koha - but it sounds to me like you're referring to their address and not the custom attributes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5872 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|julian.maurice@biblibre.com |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3378|0 |1 is obsolete| | AssignedTo|paul.poulain@biblibre.com |dev_patches@biblibre.com --- Comment #4 from dev_patches@biblibre.com 2011-04-04 16:31:36 UTC --- Created attachment 3647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3647 patch appliable for master the patch proposed could not apply any longer. This patch is rebased on master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Guillaume Hatt <guillaume.hatt@enc.sorbonne.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guillaume.hatt@enc.sorbonne | |.fr AssignedTo|dev_patches@biblibre.com |guillaume.hatt@enc.sorbonne | |.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #5 from Guillaume Hatt <guillaume.hatt@enc.sorbonne.fr> 2011-04-05 12:19:07 UTC --- I was testing last version of the patch (attachment 3647) and I saw a message that my patron has been renewed too. There's no modification of the enrollment period, it's still shown on top of the page of circulation circ/circulation.pl?borrowernumber=xxx Guillaume -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-01 02:32:03 UTC --- This is blocking bug 5872 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2011-06-07 04:04:02 UTC --- Reformatted for template toolkit and pushed to new/awaiting_qa/bug_5436 Please take a look -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev_patches@biblibre.com --- Comment #8 from dev_patches@biblibre.com 2011-06-08 19:37:45 UTC --- can't reproduce the buggy behaviour on my instance. I would like to ask the person who tested the patch to test against your branch. So that they can attest whether or not it is still happening. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #9 from Magnus Enger <magnus@enger.priv.no> 2011-07-08 09:43:59 UTC --- Sorry, I'm seeing the same as Nicole and Guillaume. I did a "git checkout origin/new/awaiting_qa/bug_5436", then did a specific search for a patron, which took me straight to the details tab for that patron (great!). But when I click on the "Check out" tab I see the message "Patron's account has been renewed until 06/30/2019". When I click on "Details" and then on "Check out" again the same message is still displayed. Doing "git checkout master" and clicking on the "Check out" tab removes the message. Confirming failed QA. BTW: This would have been so much easier to test if each separate feature/fix had it's own separate bug/patch. And this thing with the renewed-message would not be blocking all the other bits. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #10 from Magnus Enger <magnus@enger.priv.no> 2011-07-08 09:51:09 UTC --- Created attachment 4595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4595 Screenshot of the "renewed" message This is what the "renwed" message looks like. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #11 from Magnus Enger <magnus@enger.priv.no> 2011-07-08 11:02:16 UTC --- I did a clean English install with all sample data, and the "renewed" message still shows when I do "git checkout origin/new/awaiting_qa/bug_5436". I also did a clean French install with all sample data, created a library and a staff user and again the "renewed" message shows when I do "git checkout origin/new/awaiting_qa/bug_5436". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #12 from dev_patches@biblibre.com 2011-07-08 17:04:59 UTC --- finally reproduced the error. Sent a patch fixing that. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 dev_patches@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3647|0 |1 is obsolete| | --- Comment #13 from dev_patches@biblibre.com 2011-07-08 17:06:48 UTC --- Created attachment 4608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4608 followup patch. This assigns the problem of expirydate displayed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #14 from Magnus Enger <magnus@enger.priv.no> 2011-07-15 19:16:59 UTC --- Yep, attachment 4608 fixes the "renewed" message, when it is applied on top of new/awaiting_qa/bug_5436. Changing status to "Needs signoff". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #15 from Magnus Enger <magnus@enger.priv.no> 2011-07-15 23:28:24 UTC --- * When a patron search returns just 1 patron, go straight to that patron - OK * Borrower link on circ/return.pl goes to circulation.pl instead of moremembers.pl - OK * "View/Hide address" mostly works as expected, and saves some screen real estate, making more of the tabs visible on smaller screens. But there is a problem with the "Notices" tab: All the other tabs display this: Joann Duffy (23529000218553) Student (ST) Midway View/Hide address But the "Notices" displays this: Joann Duffy (23529000218553) (ST) View/Hide address The same problem exists even without the patches for the present bug - I'll check if there is a separate bug for it, or report one if there isn't. All in all - OK * Making extended attributes display in the "borrower toolbar" This patch adds a new field to all extended attributes: "Display in check-out". I created two new extended attributes, one with this field checked and one where it was not checked. The one that had it checked is displayed in the "borrower toolbar" and the other one is not displayed, as expected. The extended attributes that should display in the "borrower toolbar" is only displayed on the "Check Out" and "Details" tabs in circulation, I had expected it to show on all the tabs, but from reading the comments on the bug is seems this is what was intended, so all in all - OK. Please note: The patch has a database change in installer/data/mysql/atomicupdate/0009-patron-attr-display-checkout.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4595|0 |1 is obsolete| | Attachment #4608|0 |1 is obsolete| | --- Comment #16 from Magnus Enger <magnus@enger.priv.no> 2011-07-15 23:29:59 UTC --- Created attachment 4638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4638 Combined, signed-off patch This patch combines the changes pushed to new/awaiting_qa/bug_5436 with this follow-up patch: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4608 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #17 from Magnus Enger <magnus@enger.priv.no> 2011-07-16 11:14:06 UTC --- I have reported the problem with the "Notices" tab as Bug 6593. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5872 | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com, oleonard@myacpl.org --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 15:15:49 UTC --- QA comment * works as announced. beware the updatedatabase is in an atomicupdate file, must be added in updatedatabase before applying to master * there are a few reindenting or minor & unnecessary syntax changes, like: - my ($warning_year, $warning_month, $warning_day) = split /-/, $borrower->{'dateexpiry'}; - my ( $enrol_year, $enrol_month, $enrol_day) = split /-/, $borrower->{'dateenrolled'}; + my ($warning_year, $warning_month, $warning_day) = split (/-/, $borrower->{'dateexpiry'}); + my ( $enrol_year, $enrol_month, $enrol_day) = split (/-/, $borrower->{'dateenrolled'}); but nothing worth a failed QA * there are some properties added to staff-global.css, not sure they are all relevant (cartmenulink sounds strange. collapseaddress is used & OK). I suggest asking owen OWEN = I mark it "passed QA", if you notice something strange on staff-global, please object -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4638|0 |1 is obsolete| | --- Comment #19 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 15:16:36 UTC --- Created attachment 4829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4829 proposed patch (passed QA) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Failed QA --- Comment #20 from Owen Leonard <oleonard@myacpl.org> 2011-08-03 16:01:36 UTC --- These changes to staff-global.css should not be included: +#cartmenulink img { + background-image : none; + display : inline; + padding : 3px 6px 0 0; +} + +* html #cartmenulink { + border : 1px solid #336600; +} + +* html #listsmenulink { + border : 1px solid #006699; +} + ----------------------- In admin/patron-attr-types.tt: + <span>Check to show this attribute in member check-out.</span> The standard term is "patron," not member. ----------------------- Updates to returns.tt revert two recent improvements. The change to this template should include *only* the link to circulation.pl ----------------------- Why this change in moremember.tt? - <li><span class="label">Gender:</span> - [% IF ( sex == 'F' ) %]Female[% ELSIF ( sex == 'M' ) %]Male[% ELSE %][% sex %][% END %] - </li>[% END %] + <li><span class="label">Sex:</span>[% sex %]</li>[% END %] or this? - <li><span class="label">Username: </span>[% userid %]</li> - <li><span class="label">Password: </span> + <li><span class="label">OPAC login: </span>[% userid %]</li> + <li><span class="label">OPAC password: </span> ----------------------- All of the changes in moremember.tt to the "Relatives Checkouts" section appear to be reversions of previous corrections. Should any of this have been touched by this patch? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #21 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-04 12:08:29 UTC --- Created attachment 4838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4838 proposed patch (follow-up comment 20) (In reply to comment #20)
These changes to staff-global.css should not be included:
I've removed them in the patch i'll sent soon
In admin/patron-attr-types.tt: The standard term is "patron," not member.
right, updated too
Updates to returns.tt revert two recent improvements. The change to this template should include *only* the link to circulation.pl
OK, i've updated the patch as well
Why this change in moremember.tt?
I don't know, i've discarded all changes in moremember.tt that seems not related to this bug. Tested again, works as expected. Owen, could you check (and sign-off my follow-up. Once it's done, I think we will be able to set "passed QA", i'll ask ian/chris about that) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> 2011-08-04 17:12:37 UTC --- I'm going to split out some of the minor changes in this patch which aren't related to patron attributes, starting with Bug 6669, If a patron search returns one result, redirect to patron details page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6669 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 09:15:28 UTC --- Owen, and what about the main goal of this patch? Do you want me to take care of it or do you plan to do it as well? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Bug 5436 depends on bug 6669, which changed state. Bug 6669 Summary: If a patron search returns one result, redirect to patron details page http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6669 What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> 2011-08-05 16:29:28 UTC --- Paul I hope that when I'm done I'll have the original Extended patron attributes functionality isolated and ready to attach to this patch for evaluation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4829|0 |1 is obsolete| | Attachment #4838|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> 2011-08-05 18:59:16 UTC --- Created attachment 4872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4872 Proposed fix This patch takes changes in the previous patch and isolates just the parts relating to display of patron attributes. Because function for pulling patron attributes was merged with the function for displaying address information in SetMemberInfosInTemplate() (also found in Bug 5749), I moved the call to GetBorrowerAttributes into the individual scripts. That keeps the functionality relating specifically to patron attributes separate from the proposed changes to displaying addresses. Because I think it's important to keep the display consistent, I added display of patron attributes to all pages which include the patron information sidebar. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4872|0 |1 is obsolete| | --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-09 14:05:58 UTC --- Created attachment 4906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4906 proposed patch (signed OFF) The patch from Owen works fine. Once it has been applied, 5749 can be tested as well. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4906|0 |1 is obsolete| | --- Comment #27 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-22 02:34:33 UTC --- Created attachment 5526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5526 Signed off patch (rebased) Patch rebased to compatability with bug 3498 (partial payments) and database documentation (added documentation to new borrower_attributes.display_checkout field) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #28 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-22 02:36:08 UTC --- After fixing the merge conflicts with latest master, I'm happy to pass this patch through QA. Great new feature! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #29 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-23 03:38:08 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5436 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|5575 |6930 --- Comment #30 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-19 14:14:45 UTC --- This is causing 6390, because the atomic update is never run, adding the code to update database and pushing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org