[Bug 9529] New: Adding a patron shows javascript on screen under login section
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Bug ID: 9529 Summary: Adding a patron shows javascript on screen under login section Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Add patron shows under login section a html script tag in memberentry_messaging_prefs: / *').change(function() { message_prefs_dirty = true; }); $('#categorycode').change(function() { var categorycode = $(this).val(); if (message_prefs_dirty) { if (!confirm('Change messaging preferences to default for this category?')) { return; } } $.getJSON('/cgi-bin/koha/members/default_messageprefs.pl?categorycode=' + categorycode, function(data) { $.each(data.messaging_preferences, function(i, item) { var attrid = item.message_attribute_id; var transports = ['email', 'rss', 'sms']; $.each(transports, function(j, transport) { if (item['transport-' + transport] != ' ') { $('#' + transport + attrid).attr('checked', item['transport-' + transport]); } else { $('#' + transport + attrid).removeAttr('checked'); } }); if (item.digest && item.digest != ' ') { $('#digest' + attrid).attr('checked', item.digest); } else { $('#digest' + attrid).removeAttr('checked'); } if (item.takes_days == '1') { $('[name=' + attrid + '-DAYS]').val('' + item.days_in_advance); } }); message_prefs_dirty = false; } ); }); }); //]]> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- This appears with EnhancedMessagingPreferences set to Allow. The code is in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt The JS code can be hidden with <!-- ... -->. The confirm message needs to be between " (double quotes), can't produce a situation to trigger it. Don't know if this code is used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|Patrons |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15104&action=edit Bug 9529 - Adding a patron shows javascript on screen under login section A typo in my patch for Bug 9265 (HTML5 switch) left an extra quotation mark in a <script> tag on the patron entry form, causing JavaScript code to be output as text instead of interpreted. This patch corrects it. To test, apply the patch, enable EnhancedMessagingPreferences, and load the patron entry form. You should see no JavaScript on screen around the 'Patron messaging preferences' fieldset. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15104|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 15106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15106&action=edit Bug 9529 - Adding a patron shows javascript on screen under login section A typo in my patch for Bug 9265 (HTML5 switch) left an extra quotation mark in a <script> tag on the patron entry form, causing JavaScript code to be output as text instead of interpreted. This patch corrects it. To test, apply the patch, enable EnhancedMessagingPreferences, and load the patron entry form. You should see no JavaScript on screen around the 'Patron messaging preferences' fieldset. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9556 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15106|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15130&action=edit Bug 9529 - Adding a patron shows javascript on screen under login section A typo in my patch for Bug 9265 (HTML5 switch) left an extra quotation mark in a <script> tag on the patron entry form, causing JavaScript code to be output as text instead of interpreted. This patch corrects it. To test, apply the patch, enable EnhancedMessagingPreferences, and load the patron entry form. You should see no JavaScript on screen around the 'Patron messaging preferences' fieldset. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9529 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org