[Bug 27589] New: Error when specifying CR field in SIP Config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Bug ID: 27589 Summary: Error when specifying CR field in SIP Config Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Bug 21979 added the ability to define a custom CR field in SIP responses - the code in handle_checkin uses: $item->{$CR} but in handle_item_information: $item->$CR To recreate: 1 - set cr_item_field to 'itype' In SIP Config 2 - Attempt item_information request 3 - it Fails! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116311&action=edit Bug 27589: Unit test Previous tests only covered CHECKIN, this adds a test for ITEM_INFORMATION -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 116312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116312&action=edit Bug 27589: Access item fields as hash SIP item stores the item unblessed so field must be accessed as a hashref This patch changes the code in handle_item_information to match the code in handle_checkin To test: 1 - In sip config set the cr_item_field='itype' for a sip account 2 - Restart SIP 3 - Attempt an item information requests using the sip_cli_emulator perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m item_information --item 39999000011791 4 - It fails! 5 - Apply patch and restart 6 - It succeeds! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116311|0 |1 is obsolete| | Attachment #116312|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116313&action=edit Bug 27589: Unit test Previous tests only covered CHECKIN, this adds a test for ITEM_INFORMATION Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116313|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116315&action=edit Bug 27589: Unit test Previous tests only covered CHECKIN, this adds a test for ITEM_INFORMATION Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 116316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116316&action=edit Bug 27589: Access item fields as hash SIP item stores the item unblessed so field must be accessed as a hashref This patch changes the code in handle_item_information to match the code in handle_checkin To test: 1 - In sip config set the cr_item_field='itype' for a sip account 2 - Restart SIP 3 - Attempt an item information requests using the sip_cli_emulator perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m item_information --item 39999000011791 4 - It fails! 5 - Apply patch and restart 6 - It succeeds! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116315|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116317&action=edit Bug 27589: Unit test Previous tests only covered CHECKIN, this adds a test for ITEM_INFORMATION Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116316|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 116318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116318&action=edit Bug 27589: Access item fields as hash SIP item stores the item unblessed so field must be accessed as a hashref This patch changes the code in handle_item_information to match the code in handle_checkin To test: 1 - In sip config set the cr_item_field='itype' for a sip account 2 - Restart SIP 3 - Attempt an item information requests using the sip_cli_emulator perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL -m item_information --item 39999000011791 4 - It fails! 5 - Apply patch and restart 6 - It succeeds! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm loving that the test coverage for SIP is slowly starting to creep up and we're doing proper TDD here. Works well, solves the problem with no regressions. Passing QA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27589 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org