http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6943 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Bug 7498 depends on bug 6943, which changed state. Bug 6943 Summary: Create new budget from a copy of a previous budget http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6943 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chrish@catalyst.net.nz |fcapovilla@live.ca --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 17871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17871&action=edit Add new features and tests to the budget duplication My colleague Maxime did a patch adding this feature to the budget duplication form. The patch also adds an option to transfer the ordered acquisitions into the new budget. Unit tests were also added. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla@live.ca Change sponsored?|--- |Sponsored --- Comment #4 from Frédérick Capovilla <fcapovilla@live.ca> --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Cédric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 18341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18341&action=edit Add new features and tests to the budget duplication : * Allow to enter a new name for the duplicate * Add option to transfer the not received orders in the budget copy * Transfer the duplication code in Budgets.pm to allow easier testing. In doing this I removed the code block " # deal with any children" because I just don't understand it and it had a typo in the table name ('aqcudgets'), so I figured it was useless code * Update Budgets.t with the right field names, test the data more and tests the duplication code. Sadly I didn't write tests for the order transfers because it just depends on too much stuff :/ http://bugs.koha-community.org/show_bug.cgi?id=7498 Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #9 from Maxime Pelletier <pelletiermaxime@gmail.com> --- (In reply to comment #8)

QA comment:

All look good. I have just a little remark: after click on 'duplicate', the description field is prefilled with the original description's budget. But if the user does not change it, nothing append (no error and no creation). It would be good if a message appears (JS on submitting or after reloading the page ).

Marked as Failed QA.

I don't understand this comment. Leaving the description to the original name works fine for me and it's a wanted feature. Could you explain more or test again ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18341|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18816&action=edit Add new features and tests to the budget duplication : * Allow to enter a new name for the duplicate * Add option to transfer the not received orders in the budget copy * Transfer the duplication code in Budgets.pm to allow easier testing. In doing this I removed the code block " # deal with any children" because I just don't understand it and it had a typo in the table name ('aqcudgets'), so I figured it was useless code * Update Budgets.t with the right field names, test the data more and tests the duplication code. Sadly I didn't write tests for the order transfers because it just depends on too much stuff :/ http://bugs.koha-community.org/show_bug.cgi?id=7498 Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Test cases do not pass: $ prove -v t/db_dependent/Budgets.t ... not ok 24 - 2 budgets for that budget period : the original and his child # Failed test '2 budgets for that budget period : the original and his child' # at t/db_dependent/Budgets.t line 119. # got: '1' # expected: '2' ok 25 ok 26 ok 27 not ok 28 # Failed test at t/db_dependent/Budgets.t line 123. # got: 'P�riodiques' # expected: 'Serials' ok 29 - DelBudget returned 1 # Looks like you failed 2 tests of 29. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/29 subtests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #16 from Blou <philippe.blouin@inlibro.com> --- What do you recommend, Katrin? Moving into next year is not the same as duplicating, but I see where they could collide. We were unaware of the "duplicate" situation, and the features (simply cloning, and renaming) still seem to have value to us (and certainly the sponsor). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Blou from comment #16) You should test the new feature (see bug 12164). It certainly answers to your needs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29614|0 |1 is obsolete| | --- Comment #19 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 30562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30562&action=edit This file builds on the work done for Bug 12164 This new patch is not a stand alone feature. It is now an extension of the work done for Bug 12168, giving the user the possibility to change the cloned budget's name. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com Assignee|pelletiermaxime@gmail.com |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30562|0 |1 is obsolete| | --- Comment #21 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 30785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30785&action=edit 30562: This file builds on the work done for Bug 12164 The budget can be renamed at time of duplication. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30785|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30827&action=edit [PASSED QA] Bug 7498 - Cloning a budget, enable change of description Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) This new patch builds on the work of Bug 12164 by allowing the user to enter a new name (budget_period_description) for the cloned budget. A test was added to t/db_dependent/Budgets.t. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Charles! -- You are receiving this mail because: You are watching all bug changes.