http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44503|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 44605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44605&action=edit Bug 14743 - addorder.pl redirect problems under plack behind apache 2.4.10 I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump): HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:28:41 GMT Server: Apache/2.4.10 (Debian) Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610 Vary: User-Agent Content-Length: 0 Keep-Alive: timeout=5, max=98 Connection: Keep-Alive Content-Type: text/x-perl However, when running behind apache 2.4.10 on Debian wheezy I see chunked response: HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:21:28 GMT Server: Apache/2.4.10 (Debian) Vary: User-Agent Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/x-perl 60 Transfer-Encoding: chunked Date: Thu, 27 Aug 2015 13:21:28 GMT Connection: keep-alive 0 0 This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen). In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error! Test Plan: 1) Using plack, add an order to a basket from an external source 2) Note the error 3) Apply this patch 4) Add an order to a basket from an external source 5) Note you get no error! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44605|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44689&action=edit Bug 14743 - addorder.pl redirect problems under plack behind apache 2.4.10 I can't quite figure this out. When I run CGI version of Koha, I see following response (recorded using tcpdump): HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:28:41 GMT Server: Apache/2.4.10 (Debian) Location: /cgi-bin/koha/acqui/basket.pl?basketno=5610 Vary: User-Agent Content-Length: 0 Keep-Alive: timeout=5, max=98 Connection: Keep-Alive Content-Type: text/x-perl However, when running behind apache 2.4.10 on Debian wheezy I see chunked response: HTTP/1.1 302 Found Date: Thu, 27 Aug 2015 13:21:28 GMT Server: Apache/2.4.10 (Debian) Vary: User-Agent Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Transfer-Encoding: chunked Content-Type: text/x-perl 60 Transfer-Encoding: chunked Date: Thu, 27 Aug 2015 13:21:28 GMT Connection: keep-alive 0 0 This response doesn't work in firefox (where it reports page not found) nor in chrome (where it returns lines below 60 on screen). In the template the hidden input 'basketno' is listed twice. What the cgi script reads in the parameter, what is does is concat the values of the multiple basketno instances together createing what is likely an invalid basketno. For reasons beyond my understanding this is what triggers this error! Test Plan: 1) Using plack, add an order to a basket from an external source 2) Note the error 3) Apply this patch 4) Add an order to a basket from an external source 5) Note you get no error! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13791 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791 [Bug 13791] Plack - Out of the box support on packages -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14743 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.