[Bug 29007] New: Prompt for reason when cancelling waiting hold via popup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Bug ID: 29007 Summary: Prompt for reason when cancelling waiting hold via popup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 25534 To recreate: - have a HOLD_CANCELLATION auth value - have an item waiting for pickup for a hold - check the item in, prompting the "item is already waiting" popup - on that popup, select "Cancel" - the hold is cancelled and you are not given a chance to apply a reason Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 [Bug 25534] Add ability to specifying and store a reason when cancelling a hold -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #1 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 158337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158337&action=edit Bug 29007: Add cancellation reason input on check in Test plan: 1) Check an item in with already a confirmed hold 2) Cancel the hold, it was cancelled without possibility to choosing a reason 3) Apply this patch and do it again, you must see an input to choose your cancellation reason (list from VA) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158337|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 158473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158473&action=edit Bug 29007: Add cancellation reason input on check in Test plan: 1) Check an item in with already a confirmed hold 2) Cancel the hold, it was cancelled without possibility to choosing a reason 3) Apply this patch and do it again, you must see an input to choose your cancellation reason (list from VA) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This adds the option to release notes| |record the hold | |cancellation reason on the | |check in form for waiting | |holds (similar to when | |cancelling holds from the | |record details' holds | |page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi :) It seems to work, does anyone know where it's possible to find if a hold cancellation reason was taken into account? Without setting up emails to check the notification sent to the patron. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- About the UI, here is the before and after: https://pic.infini.fr/zdxkpN6K/WpXYQEQ5.png https://pic.infini.fr/5qEfKaF5/f5RWTWAY.png It seemed messy to me on two lines and all on the right. And someone else from QA told me it's a bit all over the place. I'm continuing to get feedback to know if that's good enough or not and **how** it should be changed. Just noticed that there is more padding with the lower edge of the window now. There definitely needs space for the dropdown because the authorized value could be long and there are language more verbose on average than english. So it's normal it can't fit with the rest. Is there a similar place in Koha to compare? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
I'm continuing to get feedback to know if that's good enough or not and **how** it should be changed.
Got another feedback about "the text above being left-aligned and the buttons right-aligned". So maybe it's mostly that that looks off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #6 from David Nind <david@davidnind.com> --- I noticed this with testing, but didn't add any comment (as it worked). Not sure if I've seen this pattern before anywhere else, and I don't have any suggestions on how to improve the display... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #7 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Victor Grousset/tuxayo from comment #4)
About the UI, here is the before and after: https://pic.infini.fr/zdxkpN6K/WpXYQEQ5.png https://pic.infini.fr/5qEfKaF5/f5RWTWAY.png
It seemed messy to me on two lines and all on the right. And someone else from QA told me it's a bit all over the place. I'm continuing to get feedback to know if that's good enough or not and **how** it should be changed.
Just noticed that there is more padding with the lower edge of the window now.
There definitely needs space for the dropdown because the authorized value could be long and there are language more verbose on average than english. So it's normal it can't fit with the rest.
Is there a similar place in Koha to compare?
Hi Victor, So the input comes from comes from the holds tab on patron details view, I delete the label element. So I put it like this on a very simple way but if the design needs to be reworked, I'd be happy to hear from you. https://pic.infini.fr/uVZne6iG/bEcWnqRM.png -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Is there a similar place in Koha to compare?
So the input comes from comes from the holds tab on patron details view [...] https://pic.infini.fr/uVZne6iG/bEcWnqRM.png
By similar place I meant a modal with the bottom starting to get crowded and needing some though in the placement of elements. ----
So I put it like this on a very simple way but if the design needs to be reworked, I'd be happy to hear from you.
I'll reach out for advice to someone more knowledgeable about UI. Maybe while I'm letting here two attempts of change with browser dev tools. (got lucky to find the CSS for alignment) left centered: https://pic.infini.fr/bWRu0B0L/CFKSoX4L.png left centered & swapped button order: https://pic.infini.fr/bNuJzlXG/oCY2D3EM.png --- (In reply to Victor Grousset/tuxayo from comment #3)
Hi :) It seems to work, does anyone know where it's possible to find if a hold cancellation reason was taken into account? Without setting up emails to check the notification sent to the patron.
About this we can use the sandboxes: https://wiki.koha-community.org/wiki/Sandboxes#Testing_sending_emails But they don't work for now (for some reason they are late on Koha commit and bug 35295 block testing this very bug) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- WARN circ/returns.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 225, now: 227) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158473|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158794&action=edit Bug 29007: Add cancellation reason input on check in Test plan: 1) Check an item in with already a confirmed hold 2) Cancel the hold, it was cancelled without possibility to choosing a reason 3) Apply this patch and do it again, you must see an input to choose your cancellation reason (list from VA) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|victor@tuxayo.net |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 | released in| | --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Marcel for validating that it's good enough. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)| |23.11.00,23.05.06 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Documentation| |kelly mcelligott contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Kelly McElligott <kelly@bywatersolutions.com> --- This documentation is done and in the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36050 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36050 [Bug 36050] Confusing notice is sent if a hold is cancelled on check-in with no reason specified -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org