[Bug 5708] New: Incorrect Discount applied to rental charge at checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Summary: Incorrect Discount applied to rental charge at checkout Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 An incorrect discount can be applied to the rental charge at checkout. Seems to be two causes 1 code does not take account of the branch where the transaction occurs. 2 code assumes that only a single value may be returned from the db which is not the case -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-02-07 17:46:39 UTC --- Created attachment 3086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3086 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Patch Status|Needs Signoff |Signed Off --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-03-04 10:26:51 UTC --- This bug is mentioned in: Bug 5708 : Get Correct Discount when levying rentalcharge http://lists.koha-community.org/pipermail/koha-patches/2011-February/013776.... --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-03-29 14:00:34 UTC --- Signing off based on this testing procedure: 1. Set up rental charges for item types, set up a discount for a patron category at a specific library. 2. Observed that before patching, the rental discount was applied to that patron category even when logged in to a different library. 3. Post-patch, rental discount was correctly applied for that patron category at the logged-in branch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Patch Pushed Severity|enhancement |normal --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-30 07:02:57 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5708 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #5 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-03-30 10:38:36 UTC --- Tested in Production -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org