[Bug 28930] New: Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Bug ID: 28930 Summary: Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails. Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org Cardnumber is lost if an invalid self registration form is submited to the server, and the server side form validation fails. I believe the idea is that the cardnumber should not be editable when requesting modifications to the borrower's details in the OPAC. But it would still make sense to keep the cardnumber field editable when correcting invalid form fields during self registration (also, see bug 17213). So, a simple fix is to let the cardnumber be editable if action != 'edit'. Test case * Enable the system preference PatronSelfRegistration * Make sure PatronSelfRegistrationBorrowerUnwantedField does not contain cardnumber. * Set the system preference GDPR_Policy to "Enforce". * In the OPAC click "Log in to your account" and "Register here". * Fill out the form with valid data, but make sure you leave the checkbox under "GDPR consent" unchecked. * Submit the form * You will get back the form with the error message "You have not filled out all required fields. Please fill in all missing fields and resubmit." * Without patch: cardnumber is not editable, and there is no input element for borrower_cardnumber (so the cardnumber will be lost when resubmitting the form) * With patch: cardnumber is editable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 124278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124278&action=edit Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master Assignee|oleonard@myacpl.org |andreas.jonsson@kreablo.se Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124278|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124320&action=edit Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration. Test plan: - Enable the system preference PatronSelfRegistration - Make sure PatronSelfRegistrationBorrowerUnwantedField does not contain cardnumber. - Set the system preference GDPR_Policy to "Enforce". - In the OPAC click "Log in to your account" and "Register here". - Fill out the form with valid data, but make sure you leave the checkbox under "GDPR consent" unchecked. - Submit the form - You will get back the form with the error message "You have not filled out all required fields. Please fill in all missing fields and resubmit." - Without patch: cardnumber is not editable, and there is no input element for borrower_cardnumber (so the cardnumber will be lost when resubmitting the form) - With patch: cardnumber is editable. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124320|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125665&action=edit Bug 28930: Keep cardnumber be editable after server side form validation fails during self registration. Test plan: - Enable the system preference PatronSelfRegistration - Make sure PatronSelfRegistrationBorrowerUnwantedField does not contain cardnumber. - Set the system preference GDPR_Policy to "Enforce". - In the OPAC click "Log in to your account" and "Register here". - Fill out the form with valid data, but make sure you leave the checkbox under "GDPR consent" unchecked. - Submit the form - You will get back the form with the error message "You have not filled out all required fields. Please fill in all missing fields and resubmit." - Without patch: cardnumber is not editable, and there is no input element for borrower_cardnumber (so the cardnumber will be lost when resubmitting the form) - With patch: cardnumber is editable. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Passing QA. This bug was actually "Fixed" already by bug 28934 which was pushed just recently but this fixes the situation where a librarian changes the Opac registration form mandatory values after the patron doing the registration has already loaded the registration page. So if GDPR option became mandatory whilst the patron was inputting the registration info this fixes it now :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cardnumber is lost if an |Cardnumber is lost if an |invalid self registration |invalid self registration |form is submited to the |form is submitted to the |server, and the server side |server, and the server side |form validation fails. |form validation fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28930 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org