[Bug 14395] New: Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Bug ID: 14395 Summary: Two different ways to calculate 'No renewal before' (days or hours) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: h.meissner.82@web.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The 'No renewal before' setting is based on the exact DateTime of the due date. This can be confusing when the loan period is measured in days, because Koha sets the time for the due date to 23:59. So with 'No renewal before' set to one day (exactly 24 hours) the loan will be renewable on the next day, but not before 23:59 when there is only one minute left of the day. There should be a syspref to ignore the exact time and only check the date. So that an item issued with 1 day 'No renewal before' will be renewable any time on the next day. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Change sponsored?|--- |Sponsored Depends on| |14101 Assignee|koha-bugs@lists.koha-commun |h.meissner.82@web.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com --- Comment #1 from bondiurbano <costalc@gmail.com> --- I agree Holger -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #2 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 41027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41027&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. To test: 1) Apply patch, then run installer/data/mysql/updatedatabase.pl 2) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #3 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 41028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41028&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Switch syspref NoRenewalBeforePrecision to 'exact time'. 2) Check out an item with 'No renewal before' set to 1 hour. Confirm that you are unable to renew. Both staff client and OPAC user account should display that renewal is allowed exactly one hour after checkout. 3) Switch NoRenewalBeforePrecision to 'date'. Now the item should be renewable immediately. (Unless you test less than an hour before midnight) 4) Also test with unit set to days and other values. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41028|0 |1 is obsolete| | --- Comment #4 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 41029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41029&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Switch syspref NoRenewalBeforePrecision to 'exact time'. 2) Check out an item with 'No renewal before' set to 1 hour. Confirm that you are unable to renew. Both staff client and OPAC user account should display that renewal is allowed exactly one hour before due. 3) Switch NoRenewalBeforePrecision to 'date'. Now the item should be renewable immediately. (Unless you test less than an hour before midnight) 4) Also test with unit set to days and other values. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #5 from Holger Meißner <h.meissner.82@web.de> --- On second thought, it's kind of pointless to have hourly loans with date-based 'No renewal before'. I'll change it, so that the syspref is only relevant for loans calculated in days. Setting back to ASSIGNED. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41027|0 |1 is obsolete| | --- Comment #6 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 41053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41053&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is always based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. This is only relevant for loans caluclated in days. Hourly loans are not affected. To test: 1) Apply bug 14101, then apply this patch. 2) Run installer/data/mysql/updatedatabase.pl 3) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41029|0 |1 is obsolete| | --- Comment #7 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 41054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Check out an hour-based loan with 'No renewal before' set to 1. Switch syspref NoRenewalBeforePrecision between 'date' and 'exact time'. Confirm that with both settings the item cannot be renewed until exactly one hour before due. 2) Check out a day-based loan with 'No renewal before' set to 1 day. Confirm that: * with NoRenewalBeforePrecision set to 'date', renewal is possible at 12:00 AM on the day before due. * with NoRenewalBeforePrecision set to 'exact time', renewal is possible at 11:59 PM on the day before due. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Holger Meißner <h.meissner.82@web.de> --- Note: With 'date' setting both OPAC user account and staff client display soonest possible renewal including time. With 'exact time' setting the staff client only displays the date. But OPAC shows the time. I couldn't figure out why yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #9 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #5)
On second thought, it's kind of pointless to have hourly loans with date-based 'No renewal before'. I'll change it, so that the syspref is only relevant for loans calculated in days. Setting back to ASSIGNED.
I think so... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #10 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #8)
Note: With 'date' setting both OPAC user account and staff client display soonest possible renewal including time. With 'exact time' setting the staff client only displays the date. But OPAC shows the time. I couldn't figure out why yet.
I think this is not relevant for now... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #11 from bondiurbano <costalc@gmail.com> --- Holger! Great job! I have tested all cases in a local virtual machine under Debian Jessie and Koha 3.20.1. All seem to work perfectly! I have tested both 14101 bug and 14395 bug together. I think it is ready for signoff. Thank you so much Holger!! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- bondiurbano - if you have tested the patches, why not sign off? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 bondiurbano <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from bondiurbano <costalc@gmail.com> --- Here I go... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- One step closer :) But we miss your signature in the patches - do you know that you can use the sandboxes for adding your sign off lines? (http://wiki.koha-community.org/wiki/Sandboxes) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #15 from bondiurbano <costalc@gmail.com> --- Glup! I'm soooooo sorry. I wrote above that I tested this issue in a local virtual machine. I did not know about what you are informing me (I am realizing I'm not the best tester!!) I'm no a programmer nor perl technician. I don't know how to procedure now... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't panic, just trying to help :) We can add your sign-off manually for these patches during the QA step. For adding your sign-off line you can use git-bz if you are using a git installation for your local testing or you can use a sandbox. The sandboxes are targetted at non-developers to help with the process of testing and signing-off - maybe something to give a try sometime :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #17 from bondiurbano <costalc@gmail.com> --- (In reply to Katrin Fischer from comment #16)
Don't panic, just trying to help :) We can add your sign-off manually for these patches during the QA step.
For adding your sign-off line you can use git-bz if you are using a git installation for your local testing or you can use a sandbox. The sandboxes are targetted at non-developers to help with the process of testing and signing-off - maybe something to give a try sometime :)
Thank you Katrin! Of course that I will give it a try as a step beyond of my learning! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #18 from Holger Meißner <h.meissner.82@web.de> --- Thank you for testing, bondiurbano! :) Please sign off 14101 as well. Git bz is a really comfortable way to do this, once you have set it up. http://wiki.koha-community.org/wiki/Git_bz_configuration -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #19 from bondiurbano <costalc@gmail.com> --- Holger, Please sign off for me this time. Git or sandboxes are misteries for me for now, despite I know that I must to learn its use as a best practice. I beg your patient. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Please add a unit tests for the two subroutines changed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #21 from bondiurbano <costalc@gmail.com> --- Created attachment 41189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41189&action=edit No renewal before TEST IN DAYS AND HOURS UNIT No renewal before TEST IN DAYS AND HOURS UNIT Tested in Debian Jessie, Koha 3.20.02 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #22 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 41197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41197&action=edit Bug 14395: Unit tests This patch fixes test cases that broke because of the changes introduced by bugs 14101 and 14395. Also adds new test cases. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Holger Meißner <h.meissner.82@web.de> --- Sorry, I forgot about the unit tests. Note that two test cases (related to bug 11634) still fail and I think they are not affected by anything I did. I'm not sure how to fix them and it probably should be done in another bug. Thanks for looking at this, Kyle! Setting back to Signed Off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Applying: Bug 14395: Add new syspref NoRenewalBeforePrecision Applying: Bug 14395: Code changes fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #25 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #23)
Sorry, I forgot about the unit tests. Note that two test cases (related to bug 11634) still fail and I think they are not affected by anything I did. I'm not sure how to fix them and it probably should be done in another bug.
Thanks for looking at this, Kyle! Setting back to Signed Off.
Holger, sorry for this comment: this patch is waiting to be fixed and sent to QA for testing. You have made a great job and it would be nice to have it in next release. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41197|0 |1 is obsolete| | --- Comment #26 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 42785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42785&action=edit Bug 14395: Unit tests This patch adds new test cases to cover the changes introduced by bug 14395. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #27 from Holger Meißner <h.meissner.82@web.de> --- Sry it took so long, bondiurbano! Now bug 14101 and 14395 have their own unit tests. Setting back to signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #28 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #27)
Sry it took so long, bondiurbano!
Now bug 14101 and 14395 have their own unit tests. Setting back to signed off.
Great job Holger! Thank you very much for your dedication and concern. Hug! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 41054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054 Bug 14395: Code changes Review of attachment 41054: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14395&attachment=41054) ----------------------------------------------------------------- Please provide a better commit description. ::: C4/Circulation.pm @@ +2772,5 @@
+ { + $soonestrenewal->truncate( to => 'day' ); + } + + if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() ) )
Prefer dt_from_string to get a DateTime object (yes this already existed before your patch, but it's worth to make things consistent). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #30 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #27)
Sry it took so long, bondiurbano!
Now bug 14101 and 14395 have their own unit tests. Setting back to signed off.
Holger! My friend! You did not abandon me, didn't you? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #31 from Holger Meißner <h.meissner.82@web.de> --- I apologize. We have a bit of staff shortage here. But don't worry, it's on my to-do-list. I hope I'll get it done next week. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #32 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #31)
I apologize. We have a bit of staff shortage here. But don't worry, it's on my to-do-list. I hope I'll get it done next week.
Thank you Holger! Nice to read you and take your time...Thanks again! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41053|0 |1 is obsolete| | --- Comment #33 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 43810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43810&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is always based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. This is only relevant for loans caluclated in days. Hourly loans are not affected. To test: 1) Apply bug 14101, then apply this patch. 2) Run installer/data/mysql/updatedatabase.pl 3) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41054|0 |1 is obsolete| | --- Comment #34 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 43811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43811&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Check out an hour-based loan with 'No renewal before' set to 1. Switch syspref NoRenewalBeforePrecision between 'date' and 'exact time'. Confirm that with both settings the item cannot be renewed until exactly one hour before due. 2) Check out a day-based loan with 'No renewal before' set to 1 day. Confirm that: * with NoRenewalBeforePrecision set to 'date', renewal is possible at 12:00 AM on the day before due. * with NoRenewalBeforePrecision set to 'exact time', renewal is possible at 11:59 PM on the day before due. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42785|0 |1 is obsolete| | --- Comment #35 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 43812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43812&action=edit Bug 14395: Unit tests This patch adds test cases for the new syspref NoRenewalBeforePrecision. Tests if GetSoonestRenewDate returns correct values for both 'date' and 'exact_time' settings. Also adds a few comments related to bugs 7413 and 14101. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #36 from Holger Meißner <h.meissner.82@web.de> --- Here you go, bondiurbano. Have a nice weekend :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #37 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #36)
Here you go, bondiurbano. Have a nice weekend :)
Thanks Holger! Impressive... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #38 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #36)
Here you go, bondiurbano. Have a nice weekend :)
Holger, the next release is ahead and it seems we have no lucky... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43810|0 |1 is obsolete| | --- Comment #39 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 44950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44950&action=edit Bug 14395: Add new syspref NoRenewalBeforePrecision Currently the 'NoRenwalBefore' setting is always based on the exact DateTime of the due date. This patch introduces a new global syspref for choosing if 'NoRenewalBefore' should instead be calculated based on date only. This is only relevant for loans caluclated in days. Hourly loans are not affected. To test: 1) Apply bug 14101, then apply this patch. 2) Run installer/data/mysql/updatedatabase.pl 3) Confirm that a new syspref NoRenewalBeforePrecision is available in administration. It should let you choose between 'date' (default) and 'exact time'. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43811|0 |1 is obsolete| | --- Comment #40 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 44951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44951&action=edit Bug 14395: Code changes This patch updates the calculation of 'No renewal before' to include the new syspref NoRenewalBeforePrecision. To test: 1) Check out an hour-based loan with 'No renewal before' set to 1. Switch syspref NoRenewalBeforePrecision between 'date' and 'exact time'. Confirm that with both settings the item cannot be renewed until exactly one hour before due. 2) Check out a day-based loan with 'No renewal before' set to 1 day. Confirm that: * with NoRenewalBeforePrecision set to 'date', renewal is possible at 12:00 AM on the day before due. * with NoRenewalBeforePrecision set to 'exact time', renewal is possible at 11:59 PM on the day before due. Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 Holger Meißner <h.meissner.82@web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43812|0 |1 is obsolete| | --- Comment #41 from Holger Meißner <h.meissner.82@web.de> --- Created attachment 44952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44952&action=edit Bug 14395: Unit tests This patch adds test cases for the new syspref NoRenewalBeforePrecision. Tests if GetSoonestRenewDate returns correct values for both 'date' and 'exact_time' settings. Also adds a few comments related to bugs 7413 and 14101. To test: 1) prove t/db_dependent/Circulation.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #42 from Holger Meißner <h.meissner.82@web.de> --- Rebased on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #43 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #42)
Rebased on master.
Holger, I do not understand what is the status of this issue... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #44 from Holger Meißner <h.meissner.82@web.de> --- Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. The QA team also has to check a lot of other bugs, so this may take some time. That's all. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #45 from bondiurbano <costalc@gmail.com> --- (In reply to Holger Meißner from comment #44)
Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. The QA team also has to check a lot of other bugs, so this may take some time. That's all.
Thanks Holger! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org