https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43706 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43675 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43675 [Bug 43675] Web installer shows a blank Installed version for outdated Perl modules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43706 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 207206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207206&action=edit Bug 43706: Fail installer tests with meaningful error when deps not satisfied If a dependency is not satisfied, the 2 selenium tests t/db_dependent/selenium/00-onboarding.t and t/db_dependent/selenium/01-installation.t fail with 12:25:54 STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} 12:25:54 /usr/share/perl5/Selenium/Remote/Driver.pm:361 in Try::Tiny::try 12:25:54 (eval 395):1 in Selenium::Remote::Driver::__ANON__ 12:25:54 (eval 397):2 in Selenium::Remote::Driver::__ANON__ 12:25:54 /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in Selenium::Remote::Driver::_execute_command 12:25:54 /usr/share/perl5/Selenium/Remote/Driver.pm:1340 in (eval) 12:25:54 t/db_dependent/selenium/01-installation.t:109 in Selenium::Remote::Driver::find_element 12:25:54 12:25:54 Error while executing command: no such element: Unable to locate element: //div[@class="alert alert-success"] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. 12:25:54 at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. With this patch they will fail with: Bailout called. Further testing stopped: Installer blocked at 'Check Perl dependencies' (Web installer › Perl modules due for upgrade): Koha | Web installer › Perl modules due for upgrade | Choose your language | Check Perl dependencies | Database settings | Set up database | Install basic configuration settings | Onboarding | Some Perl modules require upgrade. Important: Required modules must be installed at the correct version before you may continue. | Clone Required | Installed version: 0.47 | Minimum version: 42.37 | Maximum version: Test plan: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-all-tests Then remove the first "do not push" patch and confirm that they pass You don't need to wait for all the test suite to run, only the first selenium tests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43706 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43706 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I was tempted to try and also catch the perl version error we can also give here.. but I decided I've seen that so rarely and as we're considering migrating these to Cypress.. it wasn't worth the extra code now. -- You are receiving this mail because: You are watching all bug changes.