https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron statistics results |Update patron statistics |is missing page-section |report -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 161022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161022&action=edit Bug 33452: Update patron statistics search form and result list This makes changes to terminology, spelling and capitalization. Terminology used should be the same as on the normal patron form. To test: * Go to Reports > Patrons statistics * Compare search form before and after patch. List of changes: * Gender: * Add option 'Other' * Change men and women to 'Male' and 'Female' * Sort*: * Labels changed from "Sortx" to "Sort x" * Note: to see Sort 1 you need to add an AV for bsort1 * Patron status: * Options changed to start with a capital letter * 'Lost' changed to 'Lost card' * Patron activity: * Options changed to start with a capital letter * 'no active' changed to 'Not active' * Patron attributes: * Switched code and description in label, so description is first * Do a search, compare result table before and after patch. * Added white background (page-section) to results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Reports -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- I tested this out and the changes to the form labels and the display of the table look good to me. It's especially nice that the filters display accurately above the results table. While I was testing and looking at the code I noticed another small improvement could be made to the results table by right aligning the <td> elements that have numerical data. It's easily done by adding class="text-right" in a few places. Question about Bugzilla testing and submitting patches: would it be ok to add an attachment to this bug with the proposed alignment change? or should I just sign off on this bug and file a new bug for the numerical alignment and attach that change separately? Thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161022|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161472&action=edit Bug 33452: Update patron statistics search form and result list This makes changes to terminology, spelling and capitalization. Terminology used should be the same as on the normal patron form. To test: * Go to Reports > Patrons statistics * Compare search form before and after patch. List of changes: * Gender: * Add option 'Other' * Change men and women to 'Male' and 'Female' * Sort*: * Labels changed from "Sortx" to "Sort x" * Note: to see Sort 1 you need to add an AV for bsort1 * Patron status: * Options changed to start with a capital letter * 'Lost' changed to 'Lost card' * Patron activity: * Options changed to start with a capital letter * 'no active' changed to 'Not active' * Patron attributes: * Switched code and description in label, so description is first * Do a search, compare result table before and after patch. * Added white background (page-section) to results Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33452 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.