[Bug 34563] New: Move IntranetCirculationHomeHTML to HTML customizations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Bug ID: 34563 Summary: Move IntranetCirculationHomeHTML to HTML customizations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org Bug 6419 adds some HTML customizations to the staff interface. IntranetCirculationHomeHTML is still a system preference. It would be nice to move it to HTML customizations with the others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6419 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34561 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #1 from Juliet Heltibridle <jheltibridle@rcplib.org> --- It has been great being able to customize the cataloging and patron module home pages using HTML customization. Moving from a system preference to the customizations would benefit libraries in consortiums, because it is customizable per library branch. I'd love to see work done on this! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #2 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183134&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183134|0 |1 is obsolete| | --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 183142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183142&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 183150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183150&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183142|0 |1 is obsolete| | Attachment #183150|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184455&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184456&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184455|0 |1 is obsolete| | Attachment #184456|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189160&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 189161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189161&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189160|0 |1 is obsolete| | Attachment #189161|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192122&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192123&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #12 from Ray Delahunty <raymund.delahunty@outlook.com> --- Signoff failed. On an Open Fifth sandbox the new StaffCirculationHomeHTML customisation was there after patch applied and a services restart, and the data had moved from the IntranetCirculationHomeHTML system parameter. But the parameter remained present (empty). Applied a new translation and that worked, but the parameter remained present. Bug 34563 - Move IntranetCirculationHomeHTML to HTML customizations 192122 - Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations 192123 - Bug 34563: (follow-up) Change name of customization Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations Applying: Bug 34563: (follow-up) Change name of customization DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug-34563-move-IntranetCirculationHome-to-additional-contents.pl [07:09:39]: Bug 34563 - Move IntranetCirculationHomeHTML to HTML customizations Added 'StaffCirculationHomeHTML' HTML customization Removed system preference 'IntranetCirculationHomeHTML' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192122|0 |1 is obsolete| | Attachment #192123|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192143&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 192144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192144&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192143|0 |1 is obsolete| | --- Comment #15 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 192162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192162&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192144|0 |1 is obsolete| | --- Comment #16 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 192163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192163&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Sponsorship status|--- |Sponsored Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192162|0 |1 is obsolete| | Attachment #192163|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199848&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199849&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199848|0 |1 is obsolete| | Attachment #199849|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208104&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 208105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208105&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHomeHTML. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement moves the release notes| |IntranetCirculationHomeHTML | |system preference into HTML | |customizations, making it | |possible to have language- | |and library-specific | |content. Keywords|release-notes-needed | --- Comment #21 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hi Owen! Thanks again for this patch! I was trying it again to make sure it still applied. I noticed the other display locations don't have the "HTML" part (StaffAcquisitionsHome, StaffAuthoritiesHome, StaffCataloguingHome, etc.) Could you rename the new location "StaffCirculationHome" instead of StaffCirculationHomeHTML? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 212148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212148&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHome. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries Signed-off-by: Ray <raymund.delahunty@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #23 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I'm running into something testing this again and I'm not 100% sure if it's the patch or me?? At the step where I update the existing html customization, the display location that is selected is ArticleRequestsDisclaimerText (the first one in the list). StaffCirculationHome is also not in the dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #24 from Ray Delahunty <raymund.delahunty@outlook.com> --- I have so far tried 5 sandboxes across both PTFS and BibLibre using a test where there is existing content in the old IntranetCirulationHomeHTML and am seeing often changing conduct I am struggling to understand. Sometimes the new StaffCirculationHome is there after patches applied, sometimes not. Problems with translations not working, sometimes not. Am starting all tests again and will try to make sense and document what I am seeing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #25 from Ray Delahunty <raymund.delahunty@outlook.com> --- OK, my new test fully confirms what Caroline reports. The edited html customisation saved as ArticlesRequestDisclaimerText (!) and then I can't save it back to the new StaffCirculationHome as this new one is still not appearing in the dropdown list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Caroline Cyr La Rose from comment #23)
At the step where I update the existing html customization, the display location that is selected is ArticleRequestsDisclaimerText (the first one in the list).
StaffCirculationHome is also not in the dropdown list.
I think restart_all is needed to fix this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #208104|0 |1 is obsolete| | Attachment #212148|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #27 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 212308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212308&action=edit Bug 34563: Move IntranetCirculationHomeHTML to HTML customizations This patch moves the IntranetCirculationHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetCirculationHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetCirculationHomeHTML is now stored there. - The HTML customization entry form should offer IntranetCirculationHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetCirculationHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the circulation home page. You should see the content you added to the IntranetCirculationHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetCirculationHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Ray <raymund.delahunty@outlook.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #28 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 212309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=212309&action=edit Bug 34563: (follow-up) Change name of customization Based on feedback on Bug 34561, this patch renames the HTML customization from IntranetCirculationHomeHTML to StaffCirculationHome. It also removes the "page-section" class from the display of the custom content. Sponsored-by: Athens County Public Libraries Signed-off-by: Ray <raymund.delahunty@outlook.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34563 --- Comment #29 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks Owen, I was able to get the wanted behaviour with restart_all. I signed off -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org